test: replaced node-fetch with native fetch in test setup #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
force-pushed
the
test-node-fetch
branch
from
f6e2ca8 to
9a12921
Compare
aryamohanan
force-pushed
the
test-node-fetch
branch
2 times, most recently
from
8ae3d4d to
9b3dec7
Compare
Contributor
aryamohanan
force-pushed
the
test-node-fetch
branch
from
9b3dec7 to
1c4034b
Compare
aryamohanan
force-pushed
the
test-node-fetch
branch
3 times, most recently
from
a2d3f22 to
72fbfc4
Compare
aryamohanan
commented
Jan 2, 2026
aryamohanan
force-pushed
the
test-node-fetch
branch
from
b17ea69 to
f1ba9ae
Compare
aryamohanan
commented
Jan 6, 2026
aryamohanan
commented
Jan 6, 2026
Contributor
|
I believe this also needs to be removed! |
Contributor
Author
@abhilash-sivan IMO, this is not part of the test setup code. It is a minimal test application (metrics-test-app) that exists solely to be test the metrics collection. The purpose of the test is to verify that when this application runs with node-fetch as a dependency, the metrics system reports it correctly. Therefore, this dependency is not related to test setup and does not need to be replaced or removed the test explicitly requires an external dependency to validate the behavior. |
This was referenced Jan 8, 2026
aryamohanan
force-pushed
the
test-node-fetch
branch
from
217a7d6 to
d22f4af
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate test setup files from
node-fetch-v2to the nativefetchAPI available in Node.js 18+. This change removes the dependency onnode-fetch-v2in the test code and uses the built-infetchimplementation instead.Note:
This update replaces all usages of
node-fetch-v2in the test setup.Background:
node-fetch-v2: https://github.com/instana/nodejs/pull/1160/files