Skip to content

fix: Response class doesn't have exception attribute #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2025
Merged

fix: Response class doesn't have exception attribute #820

merged 1 commit into from
Nov 17, 2025
+107 −33

Conversation

@CagriYonca
Copy link
Contributor

@CagriYonca CagriYonca commented Nov 10, 2025

No description provided.

@CagriYonca CagriYonca self-assigned this Nov 10, 2025
@CagriYonca CagriYonca added the bug label Nov 10, 2025
@CagriYonca CagriYonca changed the title fix: Response class doesn't have exception attribute, Fixes: #819 fix: Response class doesn't have exception attribute Nov 10, 2025
@CagriYonca CagriYonca linked an issue Nov 10, 2025 that may be closed by this pull request
[Bug]: Pyramid instrumentation uses non-existent pyramid/webob API #819
Closed
@CagriYonca CagriYonca added fix and removed bug labels Nov 10, 2025
GSVarsha
GSVarsha reviewed Nov 11, 2025
View reviewed changes
GSVarsha
GSVarsha reviewed Nov 11, 2025
View reviewed changes
GSVarsha
GSVarsha reviewed Nov 11, 2025
View reviewed changes
GSVarsha
GSVarsha reviewed Nov 11, 2025
View reviewed changes
GSVarsha
GSVarsha requested changes Nov 11, 2025
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes

@CagriYonca CagriYonca force-pushed the fix/pyramid_api branch 2 times, most recently from 24d15cc to bfcb73e Compare November 11, 2025 11:32
@CagriYonca CagriYonca requested a review from GSVarsha November 11, 2025 11:32
@CagriYonca CagriYonca marked this pull request as ready for review November 12, 2025 09:36
@CagriYonca CagriYonca requested a review from a team as a code owner November 12, 2025 09:36
@CagriYonca CagriYonca force-pushed the fix/pyramid_api branch 2 times, most recently from 17f7aea to ddbc67c Compare November 12, 2025 10:56
pvital
pvital requested changes Nov 13, 2025
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions.

@CagriYonca CagriYonca force-pushed the fix/pyramid_api branch 4 times, most recently from 145f28c to 1a83334 Compare November 13, 2025 13:17
GSVarsha
GSVarsha reviewed Nov 17, 2025
View reviewed changes
GSVarsha
GSVarsha approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pvital
pvital requested changes Nov 17, 2025
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor change requests.

@CagriYonca CagriYonca requested a review from pvital November 17, 2025 14:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pvital
pvital approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@CagriYonca CagriYonca merged commit 9369fdd into main Nov 17, 2025
19 checks passed
@CagriYonca CagriYonca deleted the fix/pyramid_api branch November 17, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvital pvital pvital approved these changes

@GSVarsha GSVarsha GSVarsha approved these changes

Assignees

@CagriYonca CagriYonca

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Pyramid instrumentation uses non-existent pyramid/webob API

4 participants

@CagriYonca @pvital @GSVarsha