chore: use get_tracer() for all tracer access #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CagriYonca
force-pushed
the
tracer-access
branch
from
2b5870f to
408d425
Compare
Member
@CagriYonca, please, in addition to the change requests, fix this failed condition. |
Signed-off-by: Cagri Yonca <[email protected]>
Signed-off-by: Cagri Yonca <[email protected]>
CagriYonca
force-pushed
the
tracer-access
branch
from
408d425 to
9598863
Compare
…nd with_blinker) instrumentations Signed-off-by: Cagri Yonca <[email protected]>
CagriYonca
force-pushed
the
tracer-access
branch
from
a9cba61 to
2ffdf6b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use the get_tracer function to provide the correct use case of the singleton pattern, so we can start by adapting our code to getter and setters. Using singletons with getters and setters may also be helpful in resolving span_queue access management issues that arise from multi-threading with Instana.