🔒 Fix Stored XSS via REST API Meta Updates#14
Open
google-labs-jules[bot] wants to merge 1 commit intomainfrom
Open
🔒 Fix Stored XSS via REST API Meta Updates#14google-labs-jules[bot] wants to merge 1 commit intomainfrom
google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
🎯 **What:** The `update_callback` for `excerpt` and `seo_meta_desc` fields in `antigravity_cors.php` allowed direct metadata manipulation without authorization checks or sanitization.⚠️ **Risk:** Unauthenticated/unauthorized users or malicious actors could exploit this by making REST API requests with crafted `$value`s, allowing Stored XSS injection into the site's meta descriptions or excerpts. 🛡️ **Solution:** Added a `current_user_can('edit_post', $post->ID)` authorization check to both callbacks, and wrapped the incoming `$value` with `sanitize_textarea_field()` prior to database insertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What: The
⚠️ Risk: Unauthenticated/unauthorized users or malicious actors could exploit this by making REST API requests with crafted
update_callbackforexcerptandseo_meta_descfields inantigravity_cors.phpallowed direct metadata manipulation without authorization checks or sanitization.$values, allowing Stored XSS injection into the site's meta descriptions or excerpts.🛡️ Solution: Added a
current_user_can('edit_post', $post->ID)authorization check to both callbacks, and wrapped the incoming$valuewithsanitize_textarea_field()prior to database insertion.PR created automatically by Jules for task 7526099933523002537 started by @instituto-ops