This repository was archived by the owner on Feb 11, 2026. It is now read-only.
fix(launch-ec2-runner-with-fallback): Always check if an instance is launched + perform cleanup (backport #18)#20
Merged
mergify[bot] merged 1 commit intorelease-v0.1from May 21, 2025
Conversation
…launched + perform cleanup Sometimes, Git workflows are cancelled when users make pushes to a branch within a pull request. In that situation, it's possible that an EC2 instance is launched during the first workflow run but never cleaned up. Thus, we could have dangling EC2 instances. Signed-off-by: Courtney Pacheco <6019922+courtneypacheco@users.noreply.github.com> (cherry picked from commit d9fac78)
Merged
5 tasks
courtneypacheco
approved these changes
May 21, 2025
ktdreyer
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Description of this Change
Sometimes, Git workflows are cancelled when users make pushes to a branch within a pull request. In that situation, it's possible that an EC2 instance is launched during the first workflow run but never cleaned up. Thus, we could have dangling EC2 instances. Therefore, this change forces the GitHub action to always check if an instance was launched before completing. If an instance was launched, then this action will attempt to get that instance information so that information can be used to tear it down.
This is an automatic backport of pull request #18 done by Mergify.