Skip to content

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented Jun 18, 2025

This allows repos to set UV_INDEX= and still use fresh versions for
packages from the default index (pypi).

Also, remove unset for a variable that is not used by uv.

Signed-off-by: Ihar Hrachyshka [email protected]

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been added and/or updated, if applicable.
  • Unit tests have been added and/or updated. (If this is not applicable, please provide a justification.)
  • Integration testing has been performed, if applicable

Description of this Change

This allows repos to set UV_INDEX= and still use fresh versions for
packages from the default index (pypi).

Also, remove unset for a variable that is not used by `uv`.

Signed-off-by: Ihar Hrachyshka <[email protected]>

CONSTRAINTS_FILE=constraints-dev.txt

export UV_INDEX_STRATEGY=unsafe-best-match
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's called unsafe because there's an attack vector: https://docs.astral.sh/uv/concepts/indexes/#searching-across-multiple-indexes but it applies to any pip runs. Since we use pip anyway, it doesn't seem to make it any worse than status quo.

@courtneypacheco courtneypacheco merged commit 8a9dfec into instructlab:main Jun 18, 2025
12 checks passed
@mergify mergify bot added the one-approval label Jun 18, 2025
@booxter
Copy link
Contributor Author

booxter commented Jun 18, 2025

@mergify backport release-v0.2

@mergify
Copy link
Contributor

mergify bot commented Jun 18, 2025

backport release-v0.2

✅ Backports have been created

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants