Skip to content

Don't check pull_request targets #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
booxter wants to merge 1 commit into from
Closed

Don't check pull_request targets #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion actions/detect-exposed-workflow-secrets/exposed_secrets_detection/src/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ def workflow_auto_triggers_on_pull_request(trigger_conditions: list) -> bool:
# request/issue actions.
automatic_triggers = {
"issue_comment", # this can sometimes require a GitHub token stored in an env var
"pull_request",
"pull_request_comment", # this is deprecated and replaced by "issue_comment", but GitHub still allows it to be used
"pull_request_review",
"pull_request_review_comment",
Expand Down
2 changes: 1 addition & 1 deletion actions/detect-exposed-workflow-secrets/exposed_secrets_detection/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def test_workflow_auto_triggers_on_pull_request_one_automatic_trigger_exists():
trigger_conditions = [
"schedule",
"workflow_dispatch",
"pull_request",
"pull_request_target",
]
workflow_contains_auto_triggers = workflow_auto_triggers_on_pull_request(
trigger_conditions
Expand Down