fix: Require medium and large E2E jobs to use constraints-dev.txt to unblock jobs #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unblock jobs In the core repo, we are using constraints-dev.txt to constrain our dependencies in the CI: https://github.com/instructlab/instructlab/blob/main/.github/workflows/e2e-nvidia-l40s-x4.yml#L175 In this repo, we are pulling the E2E workflow from the core repo without actually passing in `-c constraints-dev.txt` Signed-off-by: Courtney Pacheco <[email protected]>
Contributor
Author
Contributor
|
Please try approach taken in instructlab/instructlab#3399 and see if it's any better. |
Contributor
|
Applying a probable fix for flash-attn issues here: #260 |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Contributor
|
#260 merged and it includes this change. This one should be closed. |
Contributor
|
No longer needed. Applied in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the core repo, we are now using a
constraints-dev.txtfile to constrain our Python dependencies in the CI: https://github.com/instructlab/instructlab/blob/main/.github/workflows/e2e-nvidia-l40s-x4.yml#L175This means our dependencies in
requirements*.txtare actually uncapped and the constraints file are restricting the versions we run in the CI.In this repo, we are pulling the E2E workflow from the core repo without actually passing in
-c constraints-dev.txt. Therefore, we're running our E2E tests against newer package versions than we want in some situations.As an example, we see PyTorch-induced errors like this below because the core repo requires
torch==2.6.0, but this repo is not constraining the version:(Source: https://github.com/instructlab/eval/actions/runs/15044193998)