Skip to content

ci: remove spelling checks #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ktdreyer wants to merge 1 commit into from
Closed

ci: remove spelling checks #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .github/mergify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,20 +73,6 @@ pull_request_rules:
- -files=.markdownlint-cli2.yaml
- -files=.github/workflows/docs.yml

- or:
- and:
- check-success=spellcheck
- or:
- files~=\.md$
- files=tox.ini
- files~=^\.spellcheck[^/]+$
- files=.github/workflows/spellcheck.yml
- and:
- -files~=\.md$
- -files=tox.ini
- -files~=^\.spellcheck[^/]+$
- -files=.github/workflows/spellcheck.yml

actions:
merge:
method: merge
Expand All @@ -101,7 +87,6 @@ pull_request_rules:
- files=scripts/ruff.sh
- files=.pre-commit-config.yaml
- files=.pylintrc
- files~=^\.spellcheck[^/]+$
- files=tox.ini
- files=.markdownlint-cli2.yaml
actions:
Expand Down
44 changes: 0 additions & 44 deletions .github/workflows/spellcheck.yml
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions .spellcheck-en-custom.txt
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions .spellcheck.yml
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,6 @@ md-lint: ## Lint markdown files
$(ECHO_PREFIX) printf " %-12s ./...\n" "[MD LINT]"
$(CMD_PREFIX) podman run --rm -v $(CURDIR):/workdir --security-opt label=disable docker.io/davidanson/markdownlint-cli2:latest > /dev/null

.PHONY: spellcheck
spellcheck: ## Spellcheck markdown files
tox p -e spellcheck

.PHONY: spellcheck-sort
spellcheck-sort: .spellcheck-en-custom.txt ## Sort spellcheck directory
sort -d -f -o $< $<

.PHONY: verify
verify: check-tox ## Run linting, typing, and formatting checks via tox
tox p -e fastlint,mypy,ruff
Expand Down
1 change: 0 additions & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ pytest-html

ruff
isort
pyspelling

mypy>=1.10.0
types-tqdm
Expand Down
13 changes: 1 addition & 12 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
[tox]
# py3-unit runs unit tests with 'python3'
# py311-unit runs the same tests with 'python3.11'
envlist = ruff, lint, mypy, spellcheck, py3-{unit, functional}
envlist = ruff, lint, mypy, py3-{unit, functional}
minversion = 4.4

[testenv]
Expand Down Expand Up @@ -71,17 +71,6 @@ commands =
./scripts/ruff.sh {posargs:fix}
allowlist_externals = ./scripts/ruff.sh

[testenv:spellcheck]
description = spell check (needs 'aspell' command)
skip_install = true
skipsdist = true
deps =
pyspelling
commands =
sh -c 'command -v aspell || (echo "aspell is not installed. Please install it." && exit 1)'
{envpython} -m pyspelling --config {toxinidir}/.spellcheck.yml --spellchecker aspell
allowlist_externals = sh

[testenv:mypy]
description = Python type checking with mypy
deps =
Expand Down
Loading