Skip to content

use validate notebooks job from ci actions repo #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anastasds merged 2 commits into from
Jun 16, 2025
Merged

use validate notebooks job from ci actions repo #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d2255b
use validate notebooks job from ci actions repo
iamemilio May 27, 2025
9c08c46
Update instructlab-knowledge-e2e.yml pin to v0.2.0 ci-actions
iamemilio May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/instructlab-knowledge-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,17 @@ jobs:
run: |
pip install ${{ env.TESTING_PIP_DEPENDENCIES }}
ipython kernel install --name "python3" --user
- name: Validate The Notebook
working-directory: ./notebooks/instructlab-knowledge
run: |
git clone https://github.com/instructlab/instructlab.git
python3 instructlab/scripts/validate_notebook.py ${{ matrix.notebooks_to_test }}
- name: Checkout "validate-notebooks" in-house CI action
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
repository: instructlab/ci-actions
path: ci-actions
ref: v0.2.0
sparse-checkout: actions/validate-notebooks
- name: Validate Jupyter Notebooks
uses: ./ci-actions/actions/validate-notebooks
with:
path: "./notebooks/instructlab-knowledge/${{ matrix.notebooks_to_test }}"
- name: Start Inference Mock Server
working-directory: ./tests/inference-mock
run: |
Expand Down