-
Notifications
You must be signed in to change notification settings - Fork 11
Add Docling conversion tutorials #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docling conversion tutorials #21
Conversation
iamemilio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a nit pick, this is great!
b02e195 to
7938ce2
Compare
|
@JustinXHale Let me know if you have any comments about the folder structure, or anything else. Thank you! |
JustinXHale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the folder structure under docs/docling-conversion/ looks clean and intuitive. I like that each .py script corresponds directly to a documented conversion technique. Maybe think about better naming structure for "mostly default settings", maybe something like baseline, default, or quickstart, so that the naming isnt as vague.
3b42046 to
d84b0f1
Compare
d84b0f1 to
a934487
Compare
|
@JustinXHale I renamed it to "standard settings". Thank you for the review! |
alimaredia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job getting this off the ground, I love how concise this is.
The only thing I could think about adding are examples of using the wrong document conversion pipeline on a document, what they look like and how users should adjust and see better results. Something like this could always be added as a follow up
Signed-off-by: Fabiano Franz <[email protected]>
Signed-off-by: Fabiano Franz <[email protected]>
Signed-off-by: Fabiano Franz <[email protected]>
a934487 to
5dcd845
Compare
RHELAI-4141
Adds a tutorial exposing a set of flags and options that are effective fixes for some of the most common issues faced in document parsing with Docling.