HOLD: Inference mock migration #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emilio Garcia <[email protected]>
Signed-off-by: Emilio Garcia <[email protected]>
alimaredia
reviewed
Jun 5, 2025
| - name: Checkout in-house CI actions | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| repository: iamemilio/ci-actions |
Contributor
There was a problem hiding this comment.
Shouldn't we be using https://github.com/instructlab/ci-actions here?
Contributor
Author
There was a problem hiding this comment.
Ya, this one is not ready to merge yet. Sorry for the premature undrafting. I still need to merge the change in ci-actoins and cut a release
Contributor
|
@iamemilio once you address the one comment I have, would the next step be to run merge the PR and run a standalone action to make sure the CI would be green going forward? |
Contributor
|
Looks like there's some overlap here with https://github.com/instructlab/examples/pull/20/files. Should we consolidate the PRs or merge one before the other? |
Contributor
Author
|
Lets do one after another on this one, because we need a fresh release of the CI actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move inference mock logic into its own library