Skip to content

Add subset selection notebook #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anastasds merged 5 commits into from
Jun 16, 2025
Merged

Add subset selection notebook #26

anastasds merged 5 commits into from
Jun 16, 2025

Conversation

@anastasds
Copy link
Contributor

@anastasds anastasds commented Jun 6, 2025

No description provided.

anastasds added 2 commits June 6, 2025 12:48
@anastasds
Add subset selection notebok
55a512a 
Signed-off-by: Anastas Stoyanovsky <[email protected]>
Signed-off-by: EC2 Default User <[email protected]>
@anastasds
Save selected chunks with metadata
d2885a5 
Signed-off-by: Anastas Stoyanovsky <[email protected]>
@anastasds anastasds marked this pull request as ready for review June 10, 2025 13:47
@anastasds
Add a bit of explanation for each step
ccb39bb 
Signed-off-by: Anastas Stoyanovsky <[email protected]>
alimaredia
alimaredia reviewed Jun 11, 2025
View reviewed changes
alimaredia
alimaredia reviewed Jun 11, 2025
View reviewed changes
@alimaredia
Copy link
Contributor

alimaredia commented Jun 11, 2025

I've reviewed this PR and have a few thoughts:

  1. I couldn't run through the notebook because I'm on a Mac. I think putting in a check for whether or not a user is on a Mac or at the very least some documentation on what platform this runs on would help greatly.
  2. Documentation, especially toward the latter half of the notebook was lacking. It doesn't have to be much, but just enough so that the users know what's happening at a high level, and what the inputs and outputs of various steps are.

fabianofranz
fabianofranz requested changes Jun 12, 2025
View reviewed changes
notebooks/instructlab-knowledge/subset-selection.ipynb Outdated
"metadata": {},
"outputs": [],
"source": [
"!sed -i -e 's ^faiss-gpu$ faiss-gpu-cu12 g' requirements.txt # fix faiss dependency; yes you can use spaces as delimiters for sed expressions\n",
Copy link
Contributor

@fabianofranz fabianofranz Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Predictability in PR reviews, in action right here. :-)

@anastasds
Tidy up and expand doc text
2726dbe 
Signed-off-by: Anastas Stoyanovsky <[email protected]>
@fabianofranz fabianofranz self-requested a review June 16, 2025 15:05
@anastasds anastasds merged commit 1f8a317 into main Jun 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianofranz fabianofranz fabianofranz approved these changes

@alimaredia alimaredia alimaredia approved these changes

@iamemilio iamemilio Awaiting requested review from iamemilio iamemilio is a code owner

@alinaryan alinaryan Awaiting requested review from alinaryan alinaryan is a code owner

@JustinXHale JustinXHale Awaiting requested review from JustinXHale JustinXHale is a code owner

@khaledsulayman khaledsulayman Awaiting requested review from khaledsulayman khaledsulayman is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anastasds @alimaredia @fabianofranz