Refactor examples repo into deep-dives and quick-starts #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimaredia
requested review from
JustinXHale,
alinaryan,
anastasds,
fabianofranz,
iamemilio and
khaledsulayman
as code owners
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/chunking/docling-chunking.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/chunking/docling-chunking.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/chunking/docling-chunking.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/chunking/docling-chunking.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/conversion/docling-conversion.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/conversion/docling-conversion.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/conversion/docling-conversion.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/conversion/docling-conversion.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/conversion/docling-conversion.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/seed-data-for-knowledge/seed-data-for-knowledge.ipynb
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/seed-data-for-knowledge/seed-data-for-knowledge.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/seed-data-for-knowledge/seed-data-for-knowledge.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/seed-data-for-knowledge/seed-data-for-knowledge.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/seed-data-for-knowledge/seed-data-for-knowledge.ipynb
Outdated
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
model-customization/data-processing/seed-data-for-knowledge/seed-data-for-knowledge.ipynb
Show resolved
Hide resolved
anastasds
reviewed
Jun 26, 2025
| "nbconvert_exporter": "python", | ||
| "pygments_lexer": "ipython3", | ||
| "version": "3.11.13" | ||
| "version": "3.12.10" |
Contributor
There was a problem hiding this comment.
Can every single piece run on 3.12?
anastasds
reviewed
Jun 26, 2025
Contributor
anastasds
left a comment
anastasds
left a comment
There was a problem hiding this comment.
Nice work, thanks for this! My comments are minor.
alimaredia
force-pushed
the
repo-refactor
branch
5 times, most recently
from
e365193 to
a08ed1d
Compare
Contributor
Author
|
@anastasds I addressed all of you suggestions, thank you for the comments they were great minor documentation changes. |
alimaredia
force-pushed
the
repo-refactor
branch
from
a08ed1d to
e32a6ff
Compare
anastasds
approved these changes
Jun 27, 2025
alimaredia
force-pushed
the
repo-refactor
branch
2 times, most recently
from
6806acc to
bf0331f
Compare
khaledsulayman
approved these changes
Jun 27, 2025
Member
|
@alimaredia looks like there's some merge conflicts maybe due to #35 merging |
Model-customization repo has deep dives for conversion, subset selection, chunking, and seed data creation. Quick starts include existing instructlab-knowledge notebook. Signed-off-by: Ali Maredia <[email protected]>
alimaredia
force-pushed
the
repo-refactor
branch
from
bf0331f to
2880b2c
Compare
Contributor
Author
|
@khaledsulayman The files with merge conflicts had been moved around, and a quick rebase fixed it. Since I've got two approvals I'm going to go ahead and merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model-customization repo has deep dives for
conversion, subset selection, chunking, and
seed data creation.
Quick starts include existing instructlab-knowledge notebook.