This repository was archived by the owner on Sep 9, 2025. It is now read-only.
fix the error not display when yaml file is incorrect #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhargrave
reviewed
Jan 15, 2025
bjhargrave
suggested changes
Jan 15, 2025
Contributor
bjhargrave
left a comment
bjhargrave
left a comment
There was a problem hiding this comment.
You should also add a test case to ensure this addresses the issue and avoid future changes from accidentally removing this feature.
Signed-off-by: reid_liu <[email protected]>
reidliu41
force-pushed
the
fix-not-display-error
branch
from
6538609 to
7e31da6
Compare
bjhargrave
approved these changes
Jan 16, 2025
Contributor
|
Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves instructlab/instructlab#2911