Skip to content

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented Jun 2, 2025

Signed-off-by: Ihar Hrachyshka [email protected]

@bbrowning
Copy link
Contributor

Will the weekly constraints updating job that will land in #638 take care of this responsibility from now on? I guess that plus a combination of us continuing to remove caps in the repo will accomplish the same thing, with regular PRs to bring in new dependency versions in a controlled way?

@booxter
Copy link
Contributor Author

booxter commented Jun 2, 2025

Yes. The immediate trigger for this cleanup is that dependabot feels entitled to update constraints files like here: instructlab/eval#271 and we want to control the process ourselves. The upper caps should generally go away so there's nothing for the dependabot to move. Lower caps should be moved forward when we know that an older version is broken, otherwise it's ok to leave it intact.

So tl;dr there's no job for dependabot in the pip world. But it will keep updating github workflow use: statements, as before.

@bbrowning bbrowning added the hold In-progress PR. Tag should be removed before merge. label Jun 2, 2025
@bbrowning
Copy link
Contributor

Approved with a hold label that we can remove once #638 merges.

@mergify mergify bot added the one-approval label Jun 2, 2025
@bbrowning bbrowning removed the hold In-progress PR. Tag should be removed before merge. label Jun 4, 2025
@bbrowning bbrowning merged commit 062cf4c into instructlab:main Jun 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants