Remove optimum dependency#407
Merged
JamesKunstle merged 1 commit intoinstructlab:mainfrom Jan 23, 2025
Merged
Conversation
Follows-up on instructlab/instructlab#2964 Signed-off-by: Fabien Dupont <fdupont@redhat.com>
mergify
bot
added
ci-failure
dependencies
tiran
reviewed
Jan 22, 2025
Contributor
tiran
left a comment
tiran
left a comment
There was a problem hiding this comment.
LGTM
Please merge after the InstructLab PR has landed.
JamesKunstle
approved these changes
Jan 23, 2025
Contributor
|
@tiran @nathan-weinberg does merging this actually need to wait for the CLI PR or can it just merge now? |
Member
|
The other PR has merged so we are good to do this either way 👍 |
nathan-weinberg
approved these changes
Jan 23, 2025
Contributor
|
@nathan-weinberg Alright rad! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows-up on instructlab/instructlab#2964