Conversation
booxter
force-pushed
the
ihrachyshka-py312-smoke-variant
branch
from
6a42d79 to
57b31f0
Compare
|
Thank you for adding this @booxter , this will be very helpful to have as we broaden the scope of software versions we intend to support. |
booxter
force-pushed
the
ihrachyshka-py312-smoke-variant
branch
from
57b31f0 to
3d8bf12
Compare
booxter
changed the title
booxter
force-pushed
the
ihrachyshka-py312-smoke-variant
branch
2 times, most recently
from
cff36ad to
bcfddb2
Compare
Yes, it's a lot of duplication. Until we have some way to generate workflows from a template, we have to have it: matrix doesn't apply because if used, it will use the same single ec2 runner for both 3.11 and 3.12 runs - and while it works, it slows down feedback almost by x2 because these are run sequentially. Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
booxter
force-pushed
the
ihrachyshka-py312-smoke-variant
branch
from
bcfddb2 to
53f9ef9
Compare
|
Leaving out EC2 runner reusable action work to a separate issue: #557 |
|
That the patch is working can be observed here for py311: https://github.com/instructlab/training/actions/runs/15148654764/job/42590466635 For 3.12 flavor, we'll have to merge the patch before we can trigger it in Workflow UI to prove it works. I don't expect issues with it; but if any arise, we'll deal with them. |
|
Not sure why mergify believes there's a ci-failure (as per label). Everything that ran is green (there's not much because pull_request_target workflows can't be validated with regular checks - hence manual execution linked above. |
|
I'm not sure about the The problem is that @JamesKunstle is marked as a reviewer and he has not approved this PR. In the past, developers handle this situation by removing pending reviewers from the PR. |
4 participants
No description provided.