Skip to content

ci: Introduce python 3.12 e2e large job flavor#563

Merged
mergify[bot] merged 1 commit intomainfrom
ihrachyshka-py312-e2e-flavor
Jun 4, 2025
Merged

ci: Introduce python 3.12 e2e large job flavor#563
mergify[bot] merged 1 commit intomainfrom
ihrachyshka-py312-e2e-flavor

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented May 22, 2025

No description provided.

@booxter booxter marked this pull request as draft May 22, 2025 15:38
@mergify mergify bot added the CI/CD Affects CI/CD configuration label May 22, 2025
@booxter
Copy link
Contributor Author

booxter commented May 22, 2025 •
edited
Loading

Test run here: https://github.com/instructlab/training/actions/runs/15193171489 (for 3.11; I can't test 3.12 until the workflow lands)

@booxter
Copy link
Contributor Author

booxter commented May 22, 2025

Reuse of ec2 start/stop logic is deferred to #557

@mergify mergify bot added the ci-failure label May 22, 2025
@booxter booxter force-pushed the ihrachyshka-py312-e2e-flavor branch from 26f44c7 to f6adbff Compare May 22, 2025 15:53
@mergify mergify bot added ci-failure and removed ci-failure labels May 22, 2025
@booxter booxter force-pushed the ihrachyshka-py312-e2e-flavor branch from f6adbff to b5452c5 Compare May 22, 2025 16:36
@mergify mergify bot added ci-failure and removed ci-failure labels May 22, 2025
@booxter booxter force-pushed the ihrachyshka-py312-e2e-flavor branch from b5452c5 to 2b2bc9a Compare May 22, 2025 16:57
@mergify mergify bot added ci-failure and removed ci-failure labels May 22, 2025
@booxter booxter force-pushed the ihrachyshka-py312-e2e-flavor branch from 2b2bc9a to 3a1ae78 Compare May 22, 2025 17:37
@mergify mergify bot removed the ci-failure label May 22, 2025
booxter
booxter commented May 22, 2025
View reviewed changes
@mergify mergify bot added the ci-failure label May 22, 2025
@booxter booxter mentioned this pull request May 28, 2025
Merged
@booxter booxter force-pushed the ihrachyshka-py312-e2e-flavor branch from 3a1ae78 to 167058a Compare May 28, 2025 15:11
@mergify mergify bot removed the ci-failure label May 28, 2025
@booxter
Copy link
Contributor Author

booxter commented May 28, 2025

Running E2E python3.11 with this change: https://github.com/instructlab/training/actions/runs/15304125860

@booxter booxter marked this pull request as ready for review May 28, 2025 19:36
@booxter booxter requested a review from a team May 28, 2025 21:41
@booxter
Copy link
Contributor Author

booxter commented May 28, 2025

May need to reconcile with #574 depending on which patch merges first.

@mergify
Copy link
Contributor

mergify bot commented May 29, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. @booxter please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 29, 2025
@booxter booxter force-pushed the ihrachyshka-py312-e2e-flavor branch from 167058a to a64779c Compare May 29, 2025 14:32
@booxter
Copy link
Contributor Author

booxter commented May 29, 2025

Resolved conflict due to slack notifs removed.

@mergify mergify bot removed the needs-rebase label May 29, 2025
@booxter
Copy link
Contributor Author

booxter commented May 29, 2025

Testing here: https://github.com/instructlab/training/actions/runs/15326298551

@booxter booxter added the hold label May 29, 2025
@booxter booxter mentioned this pull request May 29, 2025
Closed
@booxter booxter removed the hold label May 29, 2025
@mergify
Copy link
Contributor

mergify bot commented May 30, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. @booxter please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 30, 2025
@booxter
ci: Introduce python 3.12 e2e large job flavor
3d0e845 
Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
@booxter booxter force-pushed the ihrachyshka-py312-e2e-flavor branch from a64779c to 3d0e845 Compare May 30, 2025 15:25
@booxter booxter added the hold label May 30, 2025
@mergify mergify bot removed the needs-rebase label May 30, 2025
@booxter
Copy link
Contributor Author

booxter commented May 30, 2025

Testing: https://github.com/instructlab/training/actions/runs/15351197556

@booxter booxter removed the hold label May 30, 2025
@booxter booxter requested a review from RobotSail May 30, 2025 23:38
RobotSail
RobotSail reviewed May 30, 2025
View reviewed changes
RobotSail
RobotSail approved these changes May 31, 2025
View reviewed changes
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM!

@mergify mergify bot added the one-approval label May 31, 2025
@booxter booxter requested a review from a team June 4, 2025 13:41
cdoern
cdoern approved these changes Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@cdoern cdoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good -- quite similar to non py3.12 in the actual workflow yml, wonder if we could further consolidate in the future

@mergify mergify bot merged commit ef49f97 into main Jun 4, 2025
10 checks passed
@mergify mergify bot deleted the ihrachyshka-py312-e2e-flavor branch June 4, 2025 17:42
@mergify mergify bot removed the one-approval label Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdoern cdoern cdoern approved these changes

@RobotSail RobotSail RobotSail approved these changes

Assignees

No one assigned

Labels

CI/CD Affects CI/CD configuration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@booxter @cdoern @RobotSail