fix: Uncap accelerate #583
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E (NVIDIA L40S x4) workflow launched on this PR: View run |
Member
|
@booxter We cap accelerate because Dolomite + FSDP breaks with newer versions of accelerate. We need to fully deprecate Dolomite before we can raise this dependency. |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
|
e2e workflow succeeded on this PR: View run, congrats! |
Contributor
|
Dolomite is being deprecated in #589 |
Contributor
Author
|
Dolomite being removed here now: #616 |
We were holding the cap because of dolomite, but it's now removed. Signed-off-by: Ihar Hrachyshka <[email protected]>
Contributor
Author
|
Unclear if introducing such changes at this point in main branch is aligned with org plans for the branch. Feel free to re-open / re-use if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dolomite is removed and we can move forward on this.