Skip to content

Comments

Add liger smoketest#591

Closed
JamesKunstle wants to merge 2 commits intoinstructlab:mainfrom
JamesKunstle:add-liger-smoketest
Closed

Add liger smoketest#591
JamesKunstle wants to merge 2 commits intoinstructlab:mainfrom
JamesKunstle:add-liger-smoketest

Conversation

@JamesKunstle
Copy link
Contributor

@JamesKunstle JamesKunstle commented Jun 3, 2025 •
edited by booxter
Loading

requires #590 to be merged first- this PR is based on that one

Closes #462

@mergify mergify bot added testing Relates to testing ci-failure labels Jun 3, 2025
@JamesKunstle JamesKunstle force-pushed the add-liger-smoketest branch from bfb705b to 6f6a312 Compare June 3, 2025 23:48
@mergify mergify bot removed the ci-failure label Jun 3, 2025
@JamesKunstle JamesKunstle force-pushed the add-liger-smoketest branch from 6f6a312 to 86fba44 Compare June 4, 2025 00:27
@JamesKunstle
Copy link
Contributor Author

JamesKunstle commented Jun 4, 2025

solves #462

@booxter booxter added the hold label Jun 4, 2025
@mergify mergify bot added the one-approval label Jun 4, 2025
@booxter
Copy link
Contributor

booxter commented Jun 4, 2025

@Mergifyio rebase

@booxter booxter removed the hold label Jun 4, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2025

rebase

✅ Branch has been successfully rebased

@booxter booxter force-pushed the add-liger-smoketest branch from 86fba44 to d40e922 Compare June 4, 2025 17:44
@mergify mergify bot added ci-failure and removed ci-failure labels Jun 4, 2025
booxter
booxter reviewed Jun 4, 2025
View reviewed changes
tests/smoke/test_train.py

MINIMAL_TRAINING_ARGS = {
"max_seq_len": 140, # this config fits nicely on 4xL40s and may need modification for other setups
"max_batch_len": 15000,
Copy link
Contributor

@booxter booxter Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these parameters' changes intentional? why?

@booxter booxter self-requested a review June 4, 2025 19:40
@fynnsu
Copy link
Collaborator

fynnsu commented Jun 6, 2025 •
edited
Loading

Is the idea behind the param changes that this could run on a smaller ec2 instance? Should we also update the workflow file in this pr?

@mergify mergify bot added the ci-failure label Jun 20, 2025
@booxter
Copy link
Contributor

booxter commented Jun 20, 2025

@Mergifyio rebase

JamesKunstle and others added 2 commits June 20, 2025 17:02
@JamesKunstle @booxter
add Liger smoketest; parameterize LoRA test
3967f3a 
runs through Liger w/ and w/o CPUOffload
parameterizes LoRA but doesn't enable it because of memory usage bug

removes `smoketest.sh` from `tests` directory- all tests should use
pytest in the future.

Signed-off-by: James Kunstle <jkunstle@redhat.com>
@booxter
Revert changes to test parameters
a3e0fde 
Let's see if there's any issue without these changes. If not, we can
cancel / postpone changes to a separate PR.

Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2025

rebase

✅ Branch has been successfully rebased

@booxter booxter force-pushed the add-liger-smoketest branch from 8aad472 to a3e0fde Compare June 20, 2025 17:02
@mergify mergify bot added ci-failure and removed ci-failure labels Jun 20, 2025
@github-actions
Copy link

github-actions bot commented Sep 19, 2025

This pull request has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Sep 19, 2025
@mergify mergify bot removed the one-approval label Sep 19, 2025
@github-actions github-actions bot removed the stale label Sep 20, 2025
@github-actions
Copy link

github-actions bot commented Dec 19, 2025

This pull request has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Dec 19, 2025
@github-actions
Copy link

github-actions bot commented Jan 18, 2026

This pull request has been automatically closed due to inactivity. Please feel free to reopen if you intend to continue working on it!

@github-actions github-actions bot closed this Jan 18, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2026

rebase

☑️ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • any of:
    • sender = {{author}}
    • sender-permission >= write

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2026

rebase

☑️ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • any of:
    • sender = {{author}}
    • sender-permission >= write

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@booxter booxter Awaiting requested review from booxter

Assignees

No one assigned

Labels

stale testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rewrite smoke tests from tests/smoketest.sh as pytest smoke tests

3 participants

@JamesKunstle @booxter @fynnsu