Skip to content

Conversation

@nerdalert
Copy link
Member

@nerdalert nerdalert commented Nov 1, 2024

Changes the local login page from the default Patternfly form to match the SaaS login when started in dev mode. I don't really like the text but we can set it to whatever in another PR:

image

This also breaks out locallogin in a similar pattern to github login to resolve hydration errors from nextjs v15.

@nerdalert nerdalert marked this pull request as draft November 5, 2024 20:45
- Break out the local login into a new client side file to avoid
rehydration errors in nextjs v15
Signed-off-by: Brent Salisbury <[email protected]>
@nerdalert nerdalert marked this pull request as ready for review November 13, 2024 02:35
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit 09b0968 into instructlab:main Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants