Skip to content

Conversation

@jeff-phillips-18
Copy link
Collaborator

Closes [Dev] Update dashboard to provided a table view of contributions

Description

Updates the Dashboard section of the UI to be My contributions
Adds a table view and card view of the current contributions.
Adds a read-only view for contributions

Screen shots

Contributions table w/ Skills enabled

image

Action button w/ Skills enabled

image

Actions for saved contribution

image

Actions for draft contribution

image

Knowledge contribution read only view

image

Skills contribution read only view

image

Card view

image

Card view sort options

image

Card view sort direction options

image

Edit knowledge

image

Edit draft skill

image

/cc @Misjohns @beaumorley

Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Misjohns
Copy link
Collaborator

Misjohns commented May 6, 2025

Here are my initial recommendations:

  1. Anywhere we have an external icon please use the Font size - xs size for the icon.
    image
  2. New badge contrast is low. Make background #3B3FB6 with #FFFFFF text
    image
  3. Contribution statuses are Submitted and Draft. Currently showing Available.
    image
  4. Ascending/Descending sort should be a toggle icon not a dropdown on card view
    image
  5. Sort by dropdown menu items should all start with uppercase letter (title case). Once in dropdown they should be lowercase since they follow "Sort by".
  6. The pagination looks odd on card view. Is this just because your screen is small?
    image

@Misjohns
Copy link
Collaborator

Misjohns commented May 7, 2025

With My contributions being the only thing on the dashboard, we can move the Contribute and Upload actions into the page header. This gives us more space for the toolbar.

Reference #727 for updated My contribution designs

Card view

image

@Misjohns
Copy link
Collaborator

Misjohns commented May 7, 2025

Use default size outline labels: #147878 for Knowledge and #F8AE54 for Skills
Use compact size filled label: #B9DAFC for NEW

image

@jeff-phillips-18
Copy link
Collaborator Author

@Misjohns Updated:

image

image

The Upload button can be done in a follow-up.

@jeff-phillips-18 jeff-phillips-18 force-pushed the dashboard-updates branch 2 times, most recently from d2aaedd to a7b506a Compare May 7, 2025 16:36
@Misjohns
Copy link
Collaborator

Misjohns commented May 7, 2025

This should be a single button. Clicking it just swaps between the 2 sorts. Not a toggle button, sorry for the confusion. Maybe we don't put it on a button, just the icon. (see mobile sample below)
image
https://www.patternfly.org/patterns/card-view/design-guidelines#card-views-on-mobile
image

@Misjohns
Copy link
Collaborator

Misjohns commented May 7, 2025

Example of the sort icon not in button container
image

@jeff-phillips-18
Copy link
Collaborator Author

@Misjohns Updated:

image

@vishnoianil vishnoianil merged commit 8b97504 into instructlab:main May 8, 2025
6 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the dashboard-updates branch May 8, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dev] Update dashboard to provided a table view of contributions

3 participants