Skip to content

Simplify navigation for draft contributions #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
s-akhtar-baig merged 1 commit into from
Jun 10, 2025
Merged

Simplify navigation for draft contributions #852

s-akhtar-baig merged 1 commit into from
Jun 10, 2025

Conversation

@jeff-phillips-18
Copy link
Collaborator

@jeff-phillips-18 jeff-phillips-18 commented Jun 10, 2025

Description

  • Removes the need for the isDraft query item in the URL.
  • View/Edit pages check for a draft and use it if found.
  • Updates the draft save/create based on changes to the current contribution/draft. This removes drafts that do not differ from the submitted contribution.

s-akhtar-baig
s-akhtar-baig approved these changes Jun 10, 2025
View reviewed changes
Copy link
Collaborator

@s-akhtar-baig s-akhtar-baig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks, @jeff-phillips-18!

@s-akhtar-baig s-akhtar-baig merged commit 1f6678d into instructlab:main Jun 10, 2025
5 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the is-draft-simplify branch June 11, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-akhtar-baig s-akhtar-baig s-akhtar-baig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeff-phillips-18 @s-akhtar-baig