Fix findings

Author: domonkosadam

libs/horizon/src/main/java/com/instructure/horizon/features/account/AccountScreen.kt

@@ -42,6 +42,7 @@ import androidx.compose.ui.platform.LocalUriHandler
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.unit.dp
 import androidx.navigation.NavController
+import com.instructure.horizon.R
 import com.instructure.horizon.horizonui.foundation.HorizonColors
 import com.instructure.horizon.horizonui.foundation.HorizonCornerRadius
 import com.instructure.horizon.horizonui.foundation.HorizonSpace
@@ -81,7 +82,12 @@ fun AccountScreen(
 }
 
 @Composable
-private fun AccountContentScreen(state: AccountUiState, navController: NavController, onLogout: () -> Unit, switchExperience: () -> Unit) {
+private fun AccountContentScreen(
+    state: AccountUiState,
+    navController: NavController,
+    onLogout: () -> Unit,
+    switchExperience: () -> Unit
+) {
     LazyColumn(
         contentPadding = PaddingValues(24.dp)
     ) {
@@ -136,6 +142,7 @@ private fun AccountContentScreen(state: AccountUiState, navController: NavContro
                             navController,
                             onLogout,
                             switchExperience,
+                            state.onShowSnackbar,
                             clipModifier
                         )
 
@@ -156,8 +163,16 @@ private fun AccountContentScreen(state: AccountUiState, navController: NavContro
 }
 
 @Composable
-private fun AccountItem(item: AccountItemState, navController: NavController, onLogout: () -> Unit, switchExperience: () -> Unit, modifier: Modifier = Modifier) {
+private fun AccountItem(
+    item: AccountItemState,
+    navController: NavController,
+    onLogout: () -> Unit,
+    switchExperience: () -> Unit,
+    onShowSnackbar: (String) -> Unit,
+    modifier: Modifier = Modifier
+) {
     val uriHandler = LocalUriHandler.current
+    val context = LocalContext.current
     Row(
         verticalAlignment = Alignment.CenterVertically,
         modifier = modifier
@@ -168,7 +183,11 @@ private fun AccountItem(item: AccountItemState, navController: NavController, on
                     is AccountItemType.Open -> navController.navigate(item.type.route.route)
 
                     is AccountItemType.OpenExternal -> {
-                        uriHandler.openUri(item.type.url)
+                        try {
+                            uriHandler.openUri(item.type.url)
+                        } catch (_: Exception) {
+                            onShowSnackbar(context.getString(R.string.accountFailedtoOpenLinkMessage))
+                        }
                     }
 
                     is AccountItemType.LogOut -> {

libs/horizon/src/main/java/com/instructure/horizon/features/account/AccountUiState.kt

@@ -28,6 +28,7 @@ data class AccountUiState(
     val updateUserName: (String) -> Unit = {},
     val performLogout: () -> Unit = {},
     val switchExperience: () -> Unit = {},
+    val onShowSnackbar: (String) -> Unit = {},
     val restartApp: Boolean = false,
 )
 

libs/horizon/src/main/java/com/instructure/horizon/features/account/AccountViewModel.kt

@@ -53,7 +53,8 @@ class AccountViewModel @Inject constructor(
             ),
             updateUserName = ::updateUserName,
             performLogout = ::performLogout,
-            switchExperience = ::switchExperience
+            switchExperience = ::switchExperience,
+            onShowSnackbar = ::onShowSnackbar
         )
     )
     val uiState = _uiState.asStateFlow()
@@ -172,6 +173,12 @@ class AccountViewModel @Inject constructor(
         }
     }
 
+    private fun onShowSnackbar(message: String) {
+        _uiState.update {
+            it.copy(screenState = it.screenState.copy(snackbarMessage = message))
+        }
+    }
+
     private fun updateUserName(value: String) {
         _uiState.update {
             it.copy(

libs/horizon/src/main/res/values/strings.xml

@@ -440,4 +440,5 @@
     <string name="a11y_dashboardNextItemContentDescription">Next item</string>
     <string name="a11y_dashboardPreviousItemContentDescription">Previous item</string>
     <string name="dashboardPaginatedWidgetPagerMessage">%1$d of %2$d</string>
+    <string name="accountFailedtoOpenLinkMessage">Failed to open</string>
 </resources>