[MBL-19126][Student][Parent] Assignment Details DCP #3259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeakinstructure
approved these changes
Oct 2, 2025
Contributor
kdeakinstructure
left a comment
kdeakinstructure
left a comment
There was a problem hiding this comment.
QA 👍
Please merge the master and resolve conflicts before merge.
I saw you put 'Stub' on these 2 tests:
testComments_addCommentToSingleAttemptSubmission
testComments_addCommentToMultipleAttemptSubmission
but these are already fixed on master so make sure before you merge that this won't be stubbed unintentionally.
kristofnemere
requested changes
Oct 3, 2025
Contributor
kristofnemere
left a comment
kristofnemere
left a comment
There was a problem hiding this comment.
Not working offline in Student, I'll fix that later just wanted to block merging
# Conflicts: # apps/parent/src/androidTest/java/com/instructure/parentapp/utils/ParentComposeTest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/e2e/classic/FilesE2ETest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/e2e/classic/GradesE2ETest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/e2e/classic/ModulesE2ETest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/e2e/classic/ShareExtensionE2ETest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/e2e/classic/k5/ImportantDatesE2ETest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/e2e/classic/k5/ScheduleE2ETest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/e2e/classic/offline/OfflineGradesE2ETest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/e2e/classic/offline/OfflineModulesE2ETest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/interaction/ModuleInteractionTest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/interaction/NotificationInteractionTest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/interaction/PickerSubmissionUploadInteractionTest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/interaction/ScheduleInteractionTest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/interaction/SubmissionDetailsInteractionTest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/interaction/TodoInteractionTest.kt # apps/student/src/androidTest/java/com/instructure/student/ui/utils/StudentTest.kt
…' into MBL-19126-assignment-details-dcp # Conflicts: # apps/student/src/androidTest/java/com/instructure/student/ui/utils/StudentComposeTest.kt
kristofnemere
approved these changes
Oct 8, 2025
📊 Code Coverage Report✅ Student
✅ Teacher
|
tamaskozmer
requested changes
Oct 8, 2025
libs/pandautils/schemas/com.instructure.pandautils.room.appdatabase.AppDatabase/12.json
Outdated
Show resolved
Hide resolved
# Conflicts: # libs/pandautils/src/test/java/com/instructure/pandautils/features/assignments/details/AssignmentDetailsViewModelTest.kt
tamaskozmer
approved these changes
Oct 9, 2025
Contributor
|
refs: MBL-19126 affects: Student, Teacher, Parent release note:
This reverts commit c036045.
Contributor
|
Parent Install Page |
Contributor
|
Student Install Page |
Contributor
|
Teacher Install Page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan:
Create a discussion checkpoint assignment
Go to assignment details screen in Student and Parent app
refs: MBL-19126
affects: Student, Parent
release note: Details page of assignments with discussion checkpoints now shown with proper data
Checklist