[MBL-19081][All] Dependency update #3270
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates build dependencies across the Canvas Android project, migrating from KAPT to KSP for annotation processing and removing the document scanning library functionality. The changes modernize the build system and improve build performance while simplifying the codebase.
Key changes:
- Migration from KAPT to KSP for annotation processing
- Removal of document scanning functionality and related DocumentScanner library
- Update of multiple dependencies including Gradle, Android Gradle Plugin, Kotlin, and various libraries
Reviewed Changes
Copilot reviewed 94 out of 102 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| build.gradle files | Migrate from kotlin-kapt to KSP plugin and update dependency versions |
| DocumentScanner library | Complete removal of document scanning functionality |
| Student app | Remove document scanning features and related UI components |
| Global dependencies | Update to latest versions of core Android and Kotlin dependencies |
| Gradle wrapper | Update Gradle version to 8.13 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ndautils/src/main/java/com/instructure/pandautils/compose/composables/TriStateBottomSheet.kt
Show resolved
Hide resolved
...ndautils/src/main/java/com/instructure/pandautils/compose/composables/TriStateBottomSheet.kt
Show resolved
Hide resolved
tamaskozmer
left a comment
tamaskozmer
left a comment
There was a problem hiding this comment.
Approved the code, but I still need to test PSPDFKit
|
|
||
| - **UI**: Jetpack Compose (modern), XML layouts + Data Binding (legacy), Material Design 3 | ||
| - **Networking**: Retrofit 3.0, OkHttp 5.1, Apollo GraphQL 4.3 | ||
| - **Database**: Room 2.8 with Coroutines |
There was a problem hiding this comment.
Should we also maintain dependency versions here or just tell Claude to read the versions from GlobalDependencies.kt?
| const val COMPOSE_UI_TEST = "androidx.compose.ui:ui-test-junit4" | ||
| const val COMPOSE_UI_TEST_MANIFEST = "androidx.compose.ui:ui-test-manifest" | ||
| const val COMPOSE_MATERIAL_3 = "androidx.compose.material3:material3:1.4.0-alpha12" | ||
| const val COMPOSE_MATERIAL_3 = "androidx.compose.material3:material3:1.4.0" |
There was a problem hiding this comment.
Do we need to specify this version? I think it's included in the BOM. I guess we specified it previously because we had to use the alpha version.
|
QA findings:
Screen_recording_20251006_132028.mp4 |
# Conflicts: # apps/CLAUDE.md # libs/pandautils/src/main/java/com/instructure/pandautils/features/inbox/compose/InboxComposeFragment.kt
|
Parent Install Page |
|
Teacher Install Page |
|
Student Install Page |
|
Parent Install Page |
|
Student Install Page |
|
Teacher Install Page |
There was a problem hiding this comment.
- The approved box still appears after adding a note to a file, and the note menu doesn’t display very nicely either. I’m not sure if it’s possible to change this, but if not, I’ll approve it for now.
Screen_Recording_20251009_171147_Canvas.Teacher.mp4
|
Parent Install Page |
|
Teacher Install Page |
|
Student Install Page |
# Conflicts: # libs/pandautils/src/main/java/com/instructure/pandautils/features/file/upload/FileUploadEventHandler.kt # libs/pandautils/src/main/java/com/instructure/pandautils/features/speedgrader/grade/comments/SpeedGraderCommentsViewModel.kt
|
Parent Install Page |
|
Teacher Install Page |
The dependency updates increased code size causing R8 minification to run out of memory with the previous 4g heap limit.
|
Parent Install Page |
|
Teacher Install Page |
|
Student Install Page |
Test plan: Smoke test all the apps.
refs: MBL-19081
affects: Student, Teacher, Parent
release note: none
Checklist