[MBL-19385][All] Fix light mode button disappearing after rotation#3285
Merged
hermannakos merged 3 commits intomasterfrom Oct 9, 2025
Merged
[MBL-19385][All] Fix light mode button disappearing after rotation#3285hermannakos merged 3 commits intomasterfrom
hermannakos merged 3 commits intomasterfrom
Conversation
Fixed issue where the "Switch to Light Mode" button in calendar event details would disappear after screen rotation and the theme state would not persist. refs: MBL-19385 affects: Parent, Student, Teacher release note: Fixed light mode button disappearing after screen rotation in calendar event details test plan: 1. Enable dark mode on device 2. Navigate to calendar event with HTML description 3. Verify "Switch to Light Mode" button appears 4. Rotate device - button should remain visible 5. Toggle to light mode, rotate device - light mode should persist 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
hermannakos
changed the title
Contributor
|
Parent Install Page |
Contributor
|
Teacher Install Page |
Contributor
|
Student Install Page |
tamaskozmer
approved these changes
Oct 6, 2025
kristofnemere
approved these changes
Oct 6, 2025
adamNagy56
requested changes
Oct 6, 2025
Contributor
adamNagy56
left a comment
adamNagy56
left a comment
There was a problem hiding this comment.
- In the Parent and Teacher apps, the Light Mode button still disappears as before. It works correctly in the Student app.
See attached video.
Screen_Recording_20251006_223312_Canvas.Parent.mp4
kdeakinstructure
requested changes
Oct 7, 2025
📊 Code Coverage Report✅ Student
✅ Teacher
|
Contributor
|
Parent Install Page |
Contributor
|
Teacher Install Page |
Contributor
|
Student Install Page |
kdeakinstructure
approved these changes
Oct 8, 2025
Contributor
kdeakinstructure
left a comment
kdeakinstructure
left a comment
There was a problem hiding this comment.
QA 👍
There's no "Switch to Dark/Light mode" button at all when we have a To Do item type with description. Should we fix it as well? (That could be in a separate ticket if you think it's a valid issue.)
Fixed the issue where savedHtml was not being updated during configuration changes in ComposeCanvasWebViewWrapper. Changed savedHtml from a simple saved value to a MutableState that can be updated in the update block, ensuring the HTML content stays current during rotation and the light mode button remains visible. refs: MBL-19385
Contributor
|
Parent Install Page |
Contributor
|
Teacher Install Page |
Contributor
|
Student Install Page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue where the "Switch to Light Mode" button in calendar event details would disappear after screen rotation and the theme state would not persist.
refs: MBL-19385
affects: Parent, Student, Teacher
release note: Fixed light mode button disappearing after screen rotation in calendar event details
test plan:
🤖 Generated with Claude Code