[MBL-19300][Teacher] Fix push notification routing to open correct student submission in SpeedGrader #3292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udent submission in SpeedGrader Fixed an issue where tapping a push notification about a student comment would open SpeedGrader with the first submission instead of the corresponding student's submission. Changes: - Added submissionId parameter handling in SpeedGraderViewModel - When submissionIds are empty, fetch all submissions and calculate selectedItem based on the provided submissionId - Updated UI state to reflect the correct selected submission - Added comprehensive unit tests for the new behavior Test plan: Since push notifications only work in production, this can be tested using a deep link to open SpeedGrader with a specific submission ID. Verify that the correct student's submission is displayed (not the first one). refs: MBL-19300 affects: Teacher release note: Fixed an issue where tapping a push notification about a student comment would open SpeedGrader with the first submission instead of the corresponding student's submission.
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
Contributor
|
Parent Install Page |
Contributor
|
Teacher Install Page |
Contributor
|
Student Install Page |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where tapping push notifications about student comments would incorrectly open SpeedGrader with the first submission instead of the targeted student's submission.
- Added
submissionIdparameter handling to calculate the correct selected item index - Modified submission loading logic to fetch all submissions when
submissionIdsis empty and find the correct position - Updated UI state initialization to use the calculated selected item index
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SpeedGraderViewModel.kt | Added submissionId parameter handling and logic to calculate correct selectedItem index |
| SpeedGraderScreen.kt | Moved pagerState initialization inside conditional block to use updated selectedItem |
| SpeedGraderViewModelTest.kt | Added comprehensive unit tests for new submission ID routing behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...autils/src/main/java/com/instructure/pandautils/features/speedgrader/SpeedGraderViewModel.kt
Show resolved
Hide resolved
kristofnemere
approved these changes
Oct 8, 2025
kdeakinstructure
approved these changes
Oct 8, 2025
Contributor
kdeakinstructure
left a comment
kdeakinstructure
left a comment
There was a problem hiding this comment.
QA 👍 - We going to check this in production thoroughly
hermannakos
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where tapping a push notification about a student comment would open SpeedGrader with the first submission instead of the corresponding student's submission.
Changes:
Test plan: Since push notifications only work in production, this can be tested using a deep link to open SpeedGrader with a specific submission ID. Verify that the correct student's submission is displayed (not the first one).
refs: MBL-19300
affects: Teacher
release note: Fixed an issue where tapping a push notification about a student comment would open SpeedGrader with the first submission instead of the corresponding student's submission.
Checklist