[MBL-19203][Student] Push notification for teacher comment opens Assignment Details instead of Submission Details #3293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
Contributor
|
Parent Install Page |
Contributor
|
Teacher Install Page |
Contributor
|
Student Install Page |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where push notifications for teacher comments were opening Assignment Details instead of Submission Details. The change enables proper routing to the specific submission when accessed via push notification.
Key changes:
- Added submission ID parameter handling to automatically navigate to submission details when provided
- Updated routing logic to use Long type for submission ID instead of String
- Added comprehensive test coverage for the new navigation behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AssignmentDetailsViewModel.kt | Added logic to auto-navigate to submission details when submission ID is provided and matches criteria |
| AssignmentDetailsFragment.kt | Updated routing to handle submission ID as Long type and added submission ID parameter |
| AssignmentDetailsViewModelTest.kt | Added comprehensive test coverage for the new submission navigation logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...n/java/com/instructure/pandautils/features/assignments/details/AssignmentDetailsViewModel.kt
Show resolved
Hide resolved
...in/java/com/instructure/pandautils/features/assignments/details/AssignmentDetailsFragment.kt
Show resolved
Hide resolved
kristofnemere
approved these changes
Oct 8, 2025
kdeakinstructure
approved these changes
Oct 8, 2025
Contributor
kdeakinstructure
left a comment
kdeakinstructure
left a comment
There was a problem hiding this comment.
QA 👍 - We going to check this in production thoroughly
tamaskozmer
deleted the
MBL-19203-Push-notification-for-teacher-comment-opens-Assignment-Details-instead-of-Submission-Details
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: Since push notifications only work in production, this can be tested using a deep link to open the submission details with a specific submission ID. Verify that the correct student's submission is displayed (not the first one). I couldn't fix the attempt issue because the attempt number is not part of the push notification, older push notifications will still open the latest attempt but that is an edge case.
refs: MBL-19203
affects: Student
release note: Fixed an issue where submission comment push notifications wouldn't route to the submission.
Checklist