Skip to content

Conversation

@hermannakos
Copy link
Collaborator

Fix race condition causing duplicate file uploads and infinite loading indicators in SpeedGrader comments by passing file paths atomically with upload events.

refs: MBL-19275
affects: Teacher
release note: Fixed an issue where file attachments in SpeedGrader comments could be uploaded multiple times and get stuck in an infinite loading state

test plan:

  • Unit tests: All 20 tests pass including 5 new tests for file upload flows
  • Manual testing: Build and run Teacher app on emulator
  • Verify file uploads in SpeedGrader comments work correctly without duplicates

🤖 Generated with Claude Code

…te loading

Fix race condition causing duplicate file uploads and infinite loading indicators
in SpeedGrader comments by passing file paths atomically with upload events.

refs: MBL-19275
affects: Teacher
release note: Fixed an issue where file attachments in SpeedGrader comments could be uploaded multiple times and get stuck in an infinite loading state

test plan:
- Unit tests: All 20 tests pass including 5 new tests for file upload flows
- Manual testing: Build and run Teacher app on emulator
- Verify file uploads in SpeedGrader comments work correctly without duplicates

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@inst-danger
Copy link
Contributor

Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

📊 Code Coverage Report

✅ Student

  • PR Coverage: 43.38%
  • Master Coverage: 43.38%
  • Delta: +0.00%

✅ Teacher

  • PR Coverage: 24.42%
  • Master Coverage: 24.42%
  • Delta: +0.00%

✅ Pandautils

  • PR Coverage: 22.30%
  • Master Coverage: 22.20%
  • Delta: +0.09%

📈 Overall Average

  • PR Coverage: 30.03%
  • Master Coverage: 30.00%
  • Delta: +0.03%

@instructure instructure deleted a comment from inst-danger Oct 9, 2025
Copy link
Contributor

@adamNagy56 adamNagy56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

@hermannakos hermannakos merged commit 190557f into master Oct 13, 2025
8 of 10 checks passed
@hermannakos hermannakos deleted the MBL-19275-file-attachment-upload-fix-clean branch October 13, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants