Skip to content

[MBL-19392][Teacher]The comment box does not display above the keyboard completely #3296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamaskozmer merged 1 commit into from
Oct 9, 2025
Merged

[MBL-19392][Teacher]The comment box does not display above the keyboard completely #3296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions ...ure/pandautils/features/speedgrader/grade/comments/composables/SpeedGraderCommentInput.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.wrapContentHeight
import androidx.compose.foundation.relocation.BringIntoViewRequester
import androidx.compose.foundation.relocation.bringIntoViewRequester
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton
Expand All @@ -33,7 +35,13 @@ import androidx.compose.material3.Text
import androidx.compose.material3.TextField
import androidx.compose.material3.TextFieldDefaults
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Modifier
import androidx.compose.ui.focus.onFocusChanged
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.res.colorResource
Expand All @@ -44,8 +52,10 @@ import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import com.instructure.pandautils.R
import com.instructure.pandautils.compose.LocalCourseColor
import kotlinx.coroutines.delay


@OptIn(androidx.compose.foundation.ExperimentalFoundationApi::class)
@Composable
fun SpeedGraderCommentInput(
commentText: String,
Expand All @@ -57,10 +67,21 @@ fun SpeedGraderCommentInput(
isOnCommentLibrary: Boolean = false,
testTag: String = "speedGraderCommentInputField"
) {
val bringIntoViewRequester = remember { BringIntoViewRequester() }
var isFocused by remember { mutableStateOf(false) }

LaunchedEffect(isFocused, commentText) {
if (isFocused) {
delay(300) // Wait for keyboard animation
bringIntoViewRequester.bringIntoView()
}
}

Column(
modifier = modifier
.fillMaxWidth()
.wrapContentHeight()
.bringIntoViewRequester(bringIntoViewRequester)
.padding(start = 16.dp, end = 16.dp, top = 8.dp, bottom = 16.dp)
.border(
width = 1.dp,
Expand All @@ -73,6 +94,9 @@ fun SpeedGraderCommentInput(
.fillMaxWidth()
.wrapContentHeight()
.background(Color.Transparent)
.onFocusChanged { focusState ->
isFocused = focusState.isFocused
}
.testTag(testTag),
label = { Text(text = stringResource(R.string.speedGraderCommentHint)) },
value = commentText,
Expand Down
Loading