Skip to content

[MBL-19386][Student] - Bookmark list navigation bugfix #3302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdeakinstructure merged 1 commit into from
Oct 14, 2025
Merged

[MBL-19386][Student] - Bookmark list navigation bugfix #3302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/student/src/main/java/com/instructure/student/fragment/BookmarksFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,12 @@ import com.instructure.interactions.router.Route
import com.instructure.pandautils.analytics.SCREEN_VIEW_BOOKMARKS
import com.instructure.pandautils.analytics.ScreenView
import com.instructure.pandautils.binding.viewBinding
import com.instructure.pandautils.utils.*
import com.instructure.pandautils.utils.ThemePrefs
import com.instructure.pandautils.utils.ViewStyler
import com.instructure.pandautils.utils.hideKeyboard
import com.instructure.pandautils.utils.isTablet
import com.instructure.pandautils.utils.setupAsBackButton
import com.instructure.pandautils.utils.setupAsCloseButton
import com.instructure.student.R
import com.instructure.student.activity.BookmarkShortcutActivity
import com.instructure.student.adapter.BookmarkRecyclerAdapter
Expand Down Expand Up @@ -129,7 +134,9 @@ class BookmarksFragment : ParentFragment() {
recyclerAdapter = BookmarkRecyclerAdapter(requireContext(), isShortcutActivity, object : BookmarkAdapterToFragmentCallback<Bookmark> {
override fun onRowClicked(bookmark: Bookmark, position: Int, isOpenDetail: Boolean) {
bookmarkSelectedCallback(bookmark)
dismiss()
if (isShortcutActivity) {
dismiss()
}
}

override fun onRefreshFinished() {
Expand Down
Loading