Skip to content

[MBL-19020][Student] Navigating back to an unmarked "Mark as Done" requirement results in visual "Done" marking without unlocking subsequent items #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kristofnemere merged 1 commit into from
Oct 15, 2025
Merged

[MBL-19020][Student] Navigating back to an unmarked "Mark as Done" requirement results in visual "Done" marking without unlocking subsequent items #3304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...a/com/instructure/student/features/modules/progression/CourseModuleProgressionFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,11 @@ class CourseModuleProgressionFragment : ParentFragment(), Bookmarkable {
repository.markAsRead(canvasContext, moduleItem)

// Update the module item locally, needed to unlock modules as the user ViewPages through them
getCurrentModuleItem(currentPos)?.completionRequirement?.completed = true
// Only mark as completed if the requirement is satisfied by viewing (not must_mark_done)
val completionRequirement = getCurrentModuleItem(currentPos)?.completionRequirement
if (completionRequirement?.type != ModuleItem.MUST_MARK_DONE) {
completionRequirement?.completed = true
}

setupNextModule(getModuleItemGroup(currentPos))

Expand Down
Loading