-
Notifications
You must be signed in to change notification settings - Fork 108
[CLX-2928][Horizon] My progress widget #3312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed dashboard layout from LazyColumn to Column with vertical scroll, and placed TimeSpent and MyProgress widgets in a horizontal scrollable Row. This allows users to scroll through widgets horizontally if they don't fit on screen, matching the pattern used in the skill overview widget. Changes: - Replaced LazyColumn with Column + verticalScroll in DashboardScreen - Added horizontal scrollable Row containing widgets - Removed individual horizontal padding from widgets (now handled by Row) - Added 8dp spacing between widgets and 16dp end padding 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Update tests to match refactored API that now returns GraphQL types directly instead of intermediary wrapper types. Changes include: - Update DashboardTimeSpentRepositoryTest to use GetWidgetDataQuery.WidgetData and validate deserialized TimeSpentDataEntry objects - Update DashboardTimeSpentViewModelTest to test new calculation logic that converts minutesPerDay to hours and filters by available courses - Replace old parseHoursFromData tests with new tests for minutes-to-hours conversion and course filtering - Update FakeGetWidgetsManager in test infrastructure to return GraphQL types matching the refactored API All unit tests pass. UI tests compile successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Applied changes from CLX-2928-My-progress-widget branch to add a horizontal scrollable layout for the time spent widget on the dashboard. Changes: - Replaced LazyColumn with Column + verticalScroll in DashboardScreen - Added horizontal scrollable Row containing the time spent widget - Removed individual horizontal padding from widget (now handled by Row) - Added 16dp end spacing after widget This allows the widget to be part of a horizontally scrollable row, which will accommodate additional widgets in the future without requiring full-screen width for each one. Build successful. All unit tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
andrasmaczak
approved these changes
Oct 20, 2025
Contributor
Contributor
Contributor
Contributor
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: CLX-2928
affects: Horizon
release note: none