Skip to content

Conversation

@domonkosadam
Copy link
Contributor

refs: CLX-2928
affects: Horizon
release note: none

domonkosadam and others added 25 commits October 6, 2025 15:22
Changed dashboard layout from LazyColumn to Column with vertical scroll,
and placed TimeSpent and MyProgress widgets in a horizontal scrollable Row.
This allows users to scroll through widgets horizontally if they don't
fit on screen, matching the pattern used in the skill overview widget.

Changes:
- Replaced LazyColumn with Column + verticalScroll in DashboardScreen
- Added horizontal scrollable Row containing widgets
- Removed individual horizontal padding from widgets (now handled by Row)
- Added 8dp spacing between widgets and 16dp end padding

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Update tests to match refactored API that now returns GraphQL types
directly instead of intermediary wrapper types. Changes include:

- Update DashboardTimeSpentRepositoryTest to use GetWidgetDataQuery.WidgetData
  and validate deserialized TimeSpentDataEntry objects
- Update DashboardTimeSpentViewModelTest to test new calculation logic
  that converts minutesPerDay to hours and filters by available courses
- Replace old parseHoursFromData tests with new tests for minutes-to-hours
  conversion and course filtering
- Update FakeGetWidgetsManager in test infrastructure to return
  GraphQL types matching the refactored API

All unit tests pass. UI tests compile successfully.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Applied changes from CLX-2928-My-progress-widget branch to add a
horizontal scrollable layout for the time spent widget on the dashboard.

Changes:
- Replaced LazyColumn with Column + verticalScroll in DashboardScreen
- Added horizontal scrollable Row containing the time spent widget
- Removed individual horizontal padding from widget (now handled by Row)
- Added 16dp end spacing after widget

This allows the widget to be part of a horizontally scrollable row,
which will accommodate additional widgets in the future without
requiring full-screen width for each one.

Build successful. All unit tests pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@inst-danger
Copy link
Contributor

Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

Base automatically changed from CLX-2848-Time-spent-widget to master October 20, 2025 14:56
@inst-danger
Copy link
Contributor

Parent Install Page

@inst-danger
Copy link
Contributor

Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@github-actions
Copy link

📊 Code Coverage Report

✅ Student

  • PR Coverage: 44.08%
  • Master Coverage: 44.08%
  • Delta: +0.00%

✅ Teacher

  • PR Coverage: 24.84%
  • Master Coverage: 24.84%
  • Delta: +0.00%

✅ Pandautils

  • PR Coverage: 22.53%
  • Master Coverage: 22.53%
  • Delta: +0.00%

📈 Overall Average

  • PR Coverage: 30.48%
  • Master Coverage: 30.48%
  • Delta: +0.00%

@domonkosadam domonkosadam merged commit 100f423 into master Oct 21, 2025
8 of 10 checks passed
@domonkosadam domonkosadam deleted the CLX-2928-My-progress-widget branch October 21, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants