[CLX-2879][Horizon] Skill highlights widget #3320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests to match refactored API that now returns GraphQL types directly instead of intermediary wrapper types. Changes include: - Update DashboardTimeSpentRepositoryTest to use GetWidgetDataQuery.WidgetData and validate deserialized TimeSpentDataEntry objects - Update DashboardTimeSpentViewModelTest to test new calculation logic that converts minutesPerDay to hours and filters by available courses - Replace old parseHoursFromData tests with new tests for minutes-to-hours conversion and course filtering - Update FakeGetWidgetsManager in test infrastructure to return GraphQL types matching the refactored API All unit tests pass. UI tests compile successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Applied changes from CLX-2928-My-progress-widget branch to add a horizontal scrollable layout for the time spent widget on the dashboard. Changes: - Replaced LazyColumn with Column + verticalScroll in DashboardScreen - Added horizontal scrollable Row containing the time spent widget - Removed individual horizontal padding from widget (now handled by Row) - Added 16dp end spacing after widget This allows the widget to be part of a horizontally scrollable row, which will accommodate additional widgets in the future without requiring full-screen width for each one. Build successful. All unit tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
|
Parent Install Page |
Contributor
|
Teacher Install Page |
Contributor
|
Student Install Page |
andrasmaczak
requested changes
Oct 18, 2025
.../horizon/features/dashboard/widget/skillhighlights/card/DashboardSkillHighlightsCardError.kt
Show resolved
Hide resolved
...orizon/features/dashboard/widget/skillhighlights/card/DashboardSkillHighlightsCardContent.kt
Outdated
Show resolved
Hide resolved
andrasmaczak
approved these changes
Oct 18, 2025
Contributor
andrasmaczak
left a comment
andrasmaczak
left a comment
There was a problem hiding this comment.
Just some small improvements noted, looks nice beside that.
Contributor
|
Parent Install Page |
Contributor
|
Teacher Install Page |
Contributor
|
Student Install Page |
Contributor
|
Parent Install Page |
Contributor
|
Parent Install Page |
📊 Code Coverage Report✅ Student
✅ Teacher
|
Contributor
|
Teacher Install Page |
Contributor
|
Teacher Install Page |
Contributor
|
Student Install Page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: CLX-2879
affects: Horizon
release note: none