[MBL-19500][Student] Add expand/collapse functionality to conference groups #3373

kdeakinstructure · 2025-11-07T13:23:47Z

Summary

This PR adds expand/collapse functionality to the "New conferences" and "Concluded conferences" sections on the Conferences list page. Users can now tap on section headers to expand or collapse the list of conferences in that section.

Changes

Model Layer: Added state tracking for expanded/collapsed sections (isNewConferencesExpanded, isConcludedConferencesExpanded)
Events: Added HeaderClicked event and ConferenceHeaderType enum to handle section header interactions
UI: Updated conference header layout to include an expand/collapse icon that rotates based on state
Presenter: Modified to conditionally show conference items based on expansion state
Update Logic: Added handler to toggle expansion state when headers are clicked

Technical Details

Both sections start expanded by default
Sections expand/collapse independently
Icon rotates 180° when toggling between expanded/collapsed states
Uses existing Mobius architecture pattern
Added ic_expand_more.xml drawable and a11y_expand_collapse accessibility string

Test Plan

Open Student app
Navigate to a course with conferences
Go to Conferences page
Verify both "New conferences" and "Concluded conferences" sections are initially expanded
Tap on "New conferences" header - section should collapse with icon rotating
Tap on "Concluded conferences" header - section should collapse independently
Tap headers again to expand sections
Verify accessibility features work with TalkBack enabled
Test in both light and dark mode
Test on tablet/landscape orientation

Screenshots

Before	After
Headers were not interactive	Headers are now tappable with expand/collapse icons
All conferences always visible	Sections can be collapsed to hide conferences

refs: MBL-19500
affects: Student
release note: Added expand/collapse functionality to conference list sections, allowing users to hide or show "New conferences" and "Concluded conferences" groups

Checklist

E2E tests updated/added (if applicable)
Tested in dark mode
Tested in landscape mode and on tablet
Accessibility features considered (content descriptions added)
Product approval obtained (if needed)
Code follows existing patterns and conventions
Build succeeds without errors

🤖 Generated with Claude Code

…e groups Add expand/collapse functionality to "New conferences" and "Concluded conferences" sections on the Conferences list page. Changes: - Add expand/collapse state tracking in ConferenceListModel - Add HeaderClicked event handling - Add expand icon to conference section headers - Implement header click handlers to toggle section visibility - Add icon rotation animation based on expanded state Technical details: - Both sections start expanded by default - Sections expand/collapse independently - Uses existing Mobius architecture pattern - Added ic_expand_more drawable and a11y_expand_collapse string refs: MBL-19500 affects: Student release note: Added expand/collapse functionality to conference list sections 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

claude

Pull Request Review Summary

This PR adds collapsible/expandable sections to the conference list, allowing users to expand or collapse "New Conferences" and "Concluded Conferences" headers. Overall, the implementation follows a clean MVI architecture pattern and the functionality is well-structured.

✅ Positive Aspects

Clean MVI architecture with proper separation of concerns (Model, Update, Presenter, View)
State management is well-handled with expansion state tracked in the model
Good use of Kotlin data classes and sealed classes
Accessibility content description added for the expand/collapse icon
The UI changes are minimal and focused on the feature requirements

Issues Found

Code Style: Fully qualified package names used instead of imports in multiple files (ConferenceListAdapter.kt:33, ConferenceListView.kt:88, ConferenceListViewState.kt:30-34)
Theme Support: Hardcoded color #2D3B45 in ic_expand_more.xml:8 should use color resource for proper theme support
File Format: Missing newline at end of ic_expand_more.xml:9
UX Enhancement: Icon rotation could benefit from animation for smoother visual feedback (ConferenceListAdapter.kt:67)

Additional Observations

Architecture: The Mobius pattern implementation is solid, with events flowing properly through the system (HeaderClicked event → Update → Model → Presenter → View).

State Persistence: The expansion states (isNewConferencesExpanded, isConcludedConferencesExpanded) default to true, which provides a good user experience. However, consider whether these states should be persisted across app restarts for better UX continuity.

Testing Considerations:

Unit tests should verify the toggle behavior in ConferenceListUpdate
UI tests should verify the expand/collapse animation and content visibility
Consider testing edge cases like rapid clicking on headers

Performance: The implementation efficiently filters items in the presenter based on expansion state, avoiding unnecessary view binding for collapsed sections.

Overall, this is a well-implemented feature that just needs minor cleanup for code style consistency and theme support. Great work!

.../java/com/instructure/student/mobius/conferences/conference_list/ui/ConferenceListAdapter.kt

...ain/java/com/instructure/student/mobius/conferences/conference_list/ui/ConferenceListView.kt

apps/student/src/main/res/drawable/ic_expand_more.xml

.../java/com/instructure/student/mobius/conferences/conference_list/ui/ConferenceListAdapter.kt

inst-danger · 2025-11-07T13:38:29Z

Parent Install Page

inst-danger · 2025-11-07T13:41:13Z

Teacher Install Page

.../java/com/instructure/student/mobius/conferences/conference_list/ui/ConferenceListAdapter.kt

...ava/com/instructure/student/mobius/conferences/conference_list/ui/ConferenceListViewState.kt

apps/student/src/main/res/drawable/ic_expand_more.xml

apps/student/src/main/res/layout/adapter_conference_header.xml

...n/java/com/instructure/student/mobius/conferences/conference_list/ConferenceListPresenter.kt

...main/java/com/instructure/student/mobius/conferences/conference_list/ConferenceListUpdate.kt

Unit Test Updates: - Updated ConferenceListPresenterTest to reflect changes to ConferenceHeader data class - Added headerType and isExpanded parameters to existing header assertions - Added 3 new test cases for collapse functionality: * Returns only header when new conferences section is collapsed * Returns only header when concluded conferences section is collapsed * Sections can be collapsed independently - All 12 tests passing - Updated ConferenceListUpdateTest to test HeaderClicked event handling - Added 5 new test cases for header toggle behavior: * HeaderClicked with NEW_CONFERENCES toggles isNewConferencesExpanded (both directions) * HeaderClicked with CONCLUDED_CONFERENCES toggles isConcludedConferencesExpanded (both directions) * HeaderClicked only toggles the targeted section - All 11 tests passing Linter Improvements: - Applied automatic import organization - Changed icon rotation to use animate() for smooth animation (200ms duration) - Updated header layout to use existing ic_expand drawable with textDark tint - Added explicit import for ConferenceHeaderType where needed

inst-danger · 2025-11-10T19:59:52Z

Parent Install Page

github-actions · 2025-11-10T20:01:52Z

📊 Code Coverage Report

⚠️ Student

PR Coverage: 43.72%
Master Coverage: 43.82%
Delta: -0.10%

✅ Teacher

PR Coverage: 25.52%
Master Coverage: 25.52%
Delta: +0.00%

✅ Pandautils

PR Coverage: 22.43%
Master Coverage: 22.43%
Delta: +0.00%

📈 Overall Average

PR Coverage: 30.56%
Master Coverage: 30.59%
Delta: -0.03%

inst-danger · 2025-11-10T20:08:01Z

Teacher Install Page

inst-danger · 2025-11-10T22:26:13Z

Parent Install Page

github-actions · 2025-11-10T22:28:15Z

Student Install Page

inst-danger · 2025-11-10T22:31:21Z

Teacher Install Page

inst-danger · 2025-11-10T22:49:52Z

Student Install Page

apps/student/src/main/res/drawable/ic_expand_more.xml

inst-danger · 2025-11-11T08:46:49Z

Parent Install Page

inst-danger · 2025-11-11T08:48:55Z

Teacher Install Page

inst-danger · 2025-11-11T08:58:52Z

Student Install Page

adamNagy56

QA +1

claude bot reviewed Nov 7, 2025

View reviewed changes

kdeakinstructure requested a review from adamNagy56 November 10, 2025 09:03

tamaskozmer requested changes Nov 10, 2025

View reviewed changes

kdeakinstructure requested a review from tamaskozmer November 10, 2025 19:47

Fix ConferenceListRenderTest tests (add new parameters).

6f87677

tamaskozmer requested changes Nov 11, 2025

View reviewed changes

apps/student/src/main/res/drawable/ic_expand_more.xml Outdated Show resolved Hide resolved

Delete unnecessary resource.

1b68db3

kdeakinstructure requested a review from tamaskozmer November 11, 2025 08:31

tamaskozmer approved these changes Nov 11, 2025

View reviewed changes

adamNagy56 approved these changes Nov 11, 2025

View reviewed changes

kdeakinstructure merged commit 70f2fd1 into master Nov 11, 2025
26 of 28 checks passed

kdeakinstructure deleted the MBL-19500-make-conference-groups-expand-collapsable branch November 11, 2025 11:21

[MBL-19500][Student] Add expand/collapse functionality to conference groups #3373

[MBL-19500][Student] Add expand/collapse functionality to conference groups #3373

Uh oh!

Conversation

kdeakinstructure commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Technical Details

Test Plan

Screenshots

Checklist

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Pull Request Review Summary

✅ Positive Aspects

Issues Found

Additional Observations

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inst-danger commented Nov 7, 2025

Uh oh!

inst-danger commented Nov 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inst-danger commented Nov 10, 2025

Uh oh!

github-actions bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Code Coverage Report

⚠️ Student

✅ Teacher

✅ Pandautils

📈 Overall Average

Uh oh!

inst-danger commented Nov 10, 2025

Uh oh!

inst-danger commented Nov 10, 2025

Uh oh!

github-actions bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

inst-danger commented Nov 10, 2025

Uh oh!

inst-danger commented Nov 10, 2025

Uh oh!

Uh oh!

inst-danger commented Nov 11, 2025

Uh oh!

inst-danger commented Nov 11, 2025

Uh oh!

inst-danger commented Nov 11, 2025

Uh oh!

adamNagy56 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kdeakinstructure commented Nov 7, 2025 •

edited

Loading

github-actions bot commented Nov 10, 2025 •

edited

Loading

github-actions bot commented Nov 10, 2025 •

edited

Loading