[CLX-3559][Horizon] Domain Services API migration#3444
Merged
domonkosadam merged 2 commits intomasterfrom Dec 17, 2025
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR updates API base URLs for Pine, Cedar, and Redwood services, migrating from temporary/dev domains to production core infrastructure domains.
Positive Observations
- ✅ Clear migration from temporary URLs (
temp.prod.inseng.io,domain-svcs.nonprod.inseng.io) to stable production URLs (core.inseng.io) - ✅ Both debug and release configurations are updated consistently
- ✅ Changes are focused and contained to configuration only
Issues Found
- Inconsistent URL paths for release endpoints (libs/canvas-api-2/build.gradle:25-30): Cedar and Redwood release URLs include
/graphqlpath suffix, but Pine does not. This needs verification to ensure all services are using their correct production endpoints.
Recommendations
Please verify:
- Whether Pine release endpoint should also include
/graphqlpath (or if Cedar/Redwood shouldn't) - That all three services are reachable at the specified URLs in both debug and release configurations
- Consider adding a test or verification step to ensure these endpoints are valid before merging
libs/canvas-api-2/build.gradle
Outdated
| def cedarDebugBaseUrl = "https://cedar-api-dev.domain-svcs.nonprod.inseng.io" | ||
| def cedarReleaseBaseUrl = "https://cedar-api-production.us-east-1.temp.prod.inseng.io" | ||
| def cedarDebugBaseUrl = "https://cedar-api-dev.us-east-1.core.inseng.io" | ||
| def cedarReleaseBaseUrl = "https://cedar-api.us-east-1.core.inseng.io/graphql" |
There was a problem hiding this comment.
The release base URLs have inconsistent paths compared to the other services. Cedar and Redwood have /graphql appended, but Pine does not. Is this intentional?
- Pine:
https://pine-api.us-east-1.core.inseng.io(no path) - Cedar:
https://cedar-api.us-east-1.core.inseng.io/graphql - Redwood:
https://redwood-api.us-east-1.core.inseng.io/graphql
If all three services use GraphQL endpoints, they should probably be consistent. Please verify the correct endpoint paths for each service.
🧪 Unit Test Results✅ 📱 Student App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Mon, 15 Dec 2025 10:36:41 GMT |
📊 Code Coverage Report✅ Student
✅ Teacher
|
|
Student Install Page |
andrasmaczak
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: CLX-3559
affects: Student
release note: none