Fixed duplicate key issue

[tamaskozmer]

Test plan: Use a proxy to generate a To Do list response that contains two items with the same id.

[github-actions]

🧪 Unit Test Results

---

📊 Summary

• Total Tests: 0
• Failed: 0
• Skipped: 0
• Status: ⚠️ No test results found

Last updated: Thu, 18 Dec 2025 09:39:26 GMT

[claude]

Review Summary

This PR modifies the key generation strategy for LazyColumn items in the ToDoList screen. While the intention appears to be solving duplicate key issues, the implementation has concerns that should be addressed.

Issues Found

• Key uses index which breaks Compose's state preservation (line 375)
  • Using array indices in keys causes state loss and animation issues when list order changes
  • Compose keys should be stable and tied to item identity, not position
  • See inline comment for recommended solutions

What Works Well

✅ Good attempt to ensure key uniqueness by combining multiple properties
✅ Maintains the existing item rendering logic without changes

Recommendations

1. Investigate the root cause: Why is item.id not sufficient as a unique key? This should be addressed at the data layer.

2. If items can appear in multiple date groups: Use "${date.time}_${item.id}" without the index.

3. If item.id truly isn't unique: This indicates a data model problem that should be fixed rather than worked around with indices.

4. Add a comment: If there's a specific reason for this key structure, document it so future maintainers understand the rationale.

Testing Suggestions

• Verify list reordering works correctly (if applicable)
• Test filtering/sorting to ensure items maintain their state
• Check for any animation glitches when items move positions

Let me know if you need clarification on the Jetpack Compose key semantics or help investigating the duplicate key issue!

[kristofnemere]

QA+1