[MBL-19612][Teacher] Fix crash when saving file/folder settings#3457
Merged
kristofnemere merged 1 commit intomasterfrom Dec 18, 2025
Merged
[MBL-19612][Teacher] Fix crash when saving file/folder settings#3457kristofnemere merged 1 commit intomasterfrom
kristofnemere merged 1 commit intomasterfrom
Conversation
Fixed UninitializedPropertyAccessException that occurred when trying to save file or folder settings in the Teacher app. The issue was that updateFileFolder lateinit property was being initialized in the companion object's newInstance() function, where the ParcelableArg delegate wasn't accessible yet. Moved the initialization to onCreate() where the fragment's arguments have been properly parsed. Test plan: 1. Navigate to Files in Teacher app 2. Open a file or folder's edit screen 3. Change any setting (name, access, etc.) 4. Optionally rotate the device 5. Click Save 6. Verify the changes are saved without crashing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
🧪 Unit Test Results✅ 📱 Teacher App
✅ 📦 Submodules
📊 Summary
Last updated: Thu, 18 Dec 2025 10:51:15 GMT |
|
Teacher Install Page |
tamaskozmer
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a crash that occurred when saving file or folder settings in the Teacher app. The app was throwing a
UninitializedPropertyAccessExceptionwhen users tried to modify file/folder properties and save the changes.Changes
updateFileFolderproperty from the companion object'snewInstance()function to theonCreate()lifecycle methodParcelableArgdelegate is accessibleTest Plan
Issue References
refs: MBL-19612
Impact
affects: Teacher
Release Note
release note: Fixed crash when saving file or folder settings in Teacher app.
🤖 Generated with Claude Code