[MBL-19504][Student] Extend Conferences E2E test with expand/collapse functionality#3458
Merged
kdeakinstructure merged 2 commits intomasterfrom Jan 5, 2026
Conversation
Add some copyright to some test classes. refs: MBL-19504 affects: Student release note: -
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR adds license headers to test files and implements expand/collapse functionality testing for conference groups. The changes are well-structured and follow the existing test patterns.
Positive Aspects
- ✅ Proper Apache License 2.0 headers added to all modified files (correctly dated for their original creation)
- ✅ Comprehensive test coverage for the expand/collapse feature with clear assertion messages
- ✅ Good use of descriptive logging with STEP_TAG and ASSERTION_TAG
- ✅ New page object methods follow existing naming conventions
- ✅ Test verifies both collapsed and expanded states
Issues Found
- Hardcoded timeout value (ConferenceListPage.kt:51) - The
DoesNotExistAssertion(5)uses a magic number for timeout - Missing KDoc comments (ConferenceListPage.kt:50, 84) - New public methods
assertConferenceNotDisplayedandclickExpandCollapseGrouplack documentation
Code Quality
The code follows Kotlin conventions and Espresso testing patterns. The test logic is clear and maintainable. Minor improvements noted in inline comments would enhance code documentation and maintainability.
Test Coverage
The new test appropriately validates the expand/collapse functionality for conference groups, including verification that items appear and disappear as expected. The test flow is logical and thorough.
Security & Performance
No security concerns identified. The changes are test-only and don't affect production code performance.
.../student/src/androidTest/java/com/instructure/student/ui/pages/classic/ConferenceListPage.kt
Show resolved
Hide resolved
.../student/src/androidTest/java/com/instructure/student/ui/pages/classic/ConferenceListPage.kt
Show resolved
Hide resolved
.../student/src/androidTest/java/com/instructure/student/ui/pages/classic/ConferenceListPage.kt
Show resolved
Hide resolved
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
🧪 Unit Test Results✅ 📱 Student App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Fri, 19 Dec 2025 00:09:35 GMT |
|
Student Install Page |
tamaskozmer
approved these changes
Jan 5, 2026
adamNagy56
approved these changes
Jan 5, 2026
kdeakinstructure
deleted the
MBL-19504-extend-conferences-e2e-expand-collapse
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Plan
testConferencesE2E()test in ConferencesE2ETest.ktChanges
clickExpandCollapseGroup()method to ConferenceListPage to support clicking conference group headers by namerefs: MBL-19504
affects: Student
release note: none