Skip to content

Conversation

@kristofnemere
Copy link
Contributor

This PR updates outdated community.canvaslms.com URLs to the new community.instructure.com domain and improves the handling of acceptable use policy content.

Changes

  1. Find School Help URL: Updated from old community.canvaslms.com link to the current Instructure community KB article
  2. Privacy Policy URL: Extracted hardcoded URL to a constant (Const.PRIVACY_POLICY_URL) for better maintainability
  3. Acceptable Use Policy: Removed fallback URLs from routing methods since HTML content is provided by the API. The fallback URLs were potentially misleading as they pointed to generic policies rather than institution-specific policies
  4. InternalWebViewActivity: Updated Teacher app's createIntent method to accept nullable URL parameter, matching Student app implementation

Important Note on URL Removal

We intentionally removed the hardcoded fallback URLs from the acceptable use policy routers (e.g., "https://www.instructure.com/policies/acceptable-use"). These URLs were only used as fallbacks if HTML content wasn't downloaded properly. However, displaying a generic Canvas policy instead of an institution's specific acceptable use policy could provide incorrect information. It's better to show nothing than potentially misleading content.

Test plan:

  1. Launch Student, Teacher, or Parent app
  2. Navigate to Find My School page and verify help link opens correct community article
  3. Navigate to Settings > Legal
  4. Tap on "Privacy Policy" and verify it opens the correct Instructure policy page
  5. Tap on "Terms of Service" and verify it displays the HTML content correctly
  6. During login flow, if acceptable use policy is required, verify it displays the institution-specific policy content

refs: MBL-19761
affects: Student, Teacher, Parent
release note: Updated community help links to latest Instructure community URLs

Checklist

  • Follow-up e2e test ticket created or not needed
  • Run E2E test suite
  • Tested in dark mode
  • Tested in light mode
  • Test in landscape mode and/or tablet
  • A11y checked
  • Approve from product

- Update Find School help URL to new community link
- Extract privacy policy URL to constant
- Remove hardcoded fallback URLs from acceptable use policy routing
- Update Teacher InternalWebViewActivity to accept nullable URL parameter

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

📊 Code Coverage Report

✅ Student

  • PR Coverage: 43.27%
  • Master Coverage: 43.27%
  • Delta: +0.00%

✅ Teacher

  • PR Coverage: 25.47%
  • Master Coverage: 25.47%
  • Delta: +0.00%

✅ Pandautils

  • PR Coverage: 23.01%
  • Master Coverage: 23.01%
  • Delta: +0.00%

📈 Overall Average

  • PR Coverage: 30.58%
  • Master Coverage: 30.58%
  • Delta: +0.00%

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

🧪 Unit Test Results

✅ 📱 Parent App

  • Tests: 309 total, 0 failed, 0 skipped
  • Duration: 36.796s
  • Success Rate: 100%

✅ 📱 Student App

  • Tests: 1230 total, 0 failed, 0 skipped
  • Duration: 0.000s
  • Success Rate: 100%

✅ 📱 Teacher App

  • Tests: 367 total, 0 failed, 0 skipped
  • Duration: 35.683s
  • Success Rate: 100%

✅ 🌅 Horizon

  • Tests: 531 total, 0 failed, 0 skipped
  • Duration: 38.132s
  • Success Rate: 100%

✅ 📦 Submodules

  • Tests: 2797 total, 0 failed, 0 skipped
  • Duration: 49.993s
  • Success Rate: 100%

📊 Summary

  • Total Tests: 5234
  • Failed: 0
  • Skipped: 0
  • Status: ✅ All tests passed!

Last updated: Thu, 05 Feb 2026 14:19:39 GMT

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Parent Install Page

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Teacher Install Page

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Student Install Page

Copy link
Contributor

@adamNagy56 adamNagy56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

Copy link
Contributor

@kdeakinstructure kdeakinstructure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA 👍

@kristofnemere kristofnemere merged commit 3398d7a into master Feb 6, 2026
50 of 51 checks passed
@kristofnemere kristofnemere deleted the MBL-19761-update-community-links branch February 6, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants