Skip to content

Conversation

@Ahmed-Naguib93
Copy link
Contributor

What is new?

Add a11y for

  1. Chatbot
  2. Quizes
  3. FlashCards

refs: CLX-3720
builds: Student
affects: Student
release note: none

test plan: none

refs: CLX-947
builds: Student
affects: Student
release note: none

test plan: none
refs: CLX-3431, CLX-3433, CLX-3434, CLX-3435, CLX-3440, CLX-3442
builds: Student
affects: Student
release note: none

test plan: none
refs: CLX-2888, CLX-2889, CLX-2890, CLX-2891, CLX-2894
builds: Student
affects: Student
release note: none

test plan: none
refs: CLX-3720
builds: Student
affects: Student
release note: none

test plan: none
@Ahmed-Naguib93 Ahmed-Naguib93 self-assigned this Dec 26, 2025
@Ahmed-Naguib93 Ahmed-Naguib93 added the career Canvas Career Experience label Dec 26, 2025
@claude
Copy link

claude bot commented Dec 26, 2025

Claude Code Review

Updated: 2025-12-26

  • Potential null crash in AssistQuizViewModel.isCorrect(): Signature changed to accept AnswerOption? but lacks proper nil handling in error cases. The guard statement could mask silent failures when answer becomes nil unexpectedly.

  • Logic error in AssistFeedbackView feedback dismissal: The feedback message will never be seen because opacity is set to 0 immediately, then animated but the view is hidden before animation completes. The timing logic (3.0s delay) doesn't match the animation duration.

  • Type signature inconsistency in AssistFeedbackView: Changed from AssistChatMessageViewModel.OnFeedbackChange to inline (Bool?) -> Void. While compatible, this removes the abstraction and makes refactoring harder if the type changes.

  • Missing accessibility announcement context in AssistChatView: VoiceOver focus is set on new messages, but message content isn't automatically announced when focused. Consider adding accessibilityValue or accessibilityHint.

  • String formatting typo in Localizable.xcstrings: Entry 'Your answer wrong.' should be 'Your answer is wrong.' for grammatical correctness in accessibility announcements.

✅ Approved

@inst-danger
Copy link
Contributor

inst-danger commented Dec 26, 2025

Warnings
⚠️ This pull request will not generate a release note.

Affected Apps: Student

Builds: Student

Coverage New % Master % Delta
Canvas iOS 91.23% 81.06% 10.16%

Generated by 🚫 dangerJS against f419bbc

@inst-danger
Copy link
Contributor

inst-danger commented Dec 26, 2025

Builds

Commit: Merge branch 'master' into feature/career-add-a11y-chatbot-CLX-3720 (f419bbc)
Build Number: 1095
Built At: Jan 06 13:46 CET (01/06 05:46 AM MST)

Student

szabinst
szabinst previously approved these changes Jan 6, 2026
Base automatically changed from feature/career-program-a11y-CLX-2888 to master January 6, 2026 11:30
@Ahmed-Naguib93 Ahmed-Naguib93 dismissed szabinst’s stale review January 6, 2026 11:30

The base branch was changed.

@Ahmed-Naguib93 Ahmed-Naguib93 merged commit d15626a into master Jan 8, 2026
5 checks passed
@Ahmed-Naguib93 Ahmed-Naguib93 deleted the feature/career-add-a11y-chatbot-CLX-3720 branch January 8, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

career Canvas Career Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants