Skip to content

Conversation

@domonkosadam
Copy link
Contributor

The AI endpoints on the current production Journey API won't work without the pine and cedar workflows. It will be fixed on the backend side as well, but to ensure seamless transition between the versions we should add the additional workflows on client-side.

Test plan:

  1. With a production account, AI Assist doesn't work
  2. With this change AI Assist works properly in the production environment

@domonkosadam domonkosadam self-assigned this Jan 7, 2026
@domonkosadam domonkosadam added the career Canvas Career Experience label Jan 7, 2026
@domonkosadam domonkosadam requested a review from rh12 January 7, 2026 09:17
@claude
Copy link

claude bot commented Jan 7, 2026

Claude Code Review

APPROVED

  • Change correctly returns an array of workflows for JWT token requests
  • .journey service now properly includes pine and cedar workflows as needed for production API compatibility
  • .redwood correctly returns only itself
  • New DomainServiceWorkflow enum properly supports all workflow types (journey, redwood, pine, cedar)
  • Code integrates cleanly with existing JWTTokenRequest usage in DomainJWTService
  • No breaking changes: return type updated from [DomainServiceOption] to [DomainServiceWorkflow] but usage is compatible
  • Resolves production AI Assist functionality issue

@inst-danger
Copy link
Contributor

Builds

No apps were built for this pull request.

To trigger app builds, include a line starting with builds: followed by app names (Student, Teacher, Parent, or All) in your pull request's message.

Commit: Add addition workflows for journey API (dda557b)
Built At: Jan 07 10:19 CET (01/07 02:19 AM MST)

@inst-danger
Copy link
Contributor

Fails
🚫

Please add a release note. If no release note is wanted, use none. Example: release note: Fixed a bug that prevented users from enjoying the app.

🚫

Please add which apps this change affects. Example: affects: Teacher, Student or affects: none

🚫

Please add which apps should be built for testing this PR. Example: builds: Student, Teacher or builds: All

🚫

Please add a reference to a Jira ticket. For example: refs: MBL-10023

Warnings
⚠️ One or more files are below the minimum test coverage 50%
Coverage New % Master % Delta
Canvas iOS 91.19% 81.06% 10.13%
Core/Core/Common/Extensions/PDFKit/PDFDocumentExtensions.swift 0% -- --

Generated by 🚫 dangerJS against dda557b

@Ahmed-Naguib93 Ahmed-Naguib93 merged commit 71f2c06 into master Jan 7, 2026
5 of 6 checks passed
@Ahmed-Naguib93 Ahmed-Naguib93 deleted the Additional-workflows-for-Journey-token branch January 7, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

career Canvas Career Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants