-
Notifications
You must be signed in to change notification settings - Fork 121
[MBL-19531][S] Dashboard Hello widget #3869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
refs: builds: affects: release note: test plan:
# Conflicts: # Student/Student/Localizable.xcstrings
refs: MBL-19531 builds: Student affects: Student release note: none
BuildsCommit: Capturing weak and unnecessary self removal (71db864) |
Student/Student/LearnerDashboard/Widgets/HelloWidget/Model/DayPeriodProvider.swift
Outdated
Show resolved
Hide resolved
Student/Student/LearnerDashboard/Widgets/HelloWidget/View/HelloWidgetView.swift
Outdated
Show resolved
Hide resolved
Student/Student/LearnerDashboard/Widgets/HelloWidget/View/HelloWidgetView.swift
Outdated
Show resolved
Hide resolved
Student/Student/LearnerDashboard/Widgets/HelloWidget/ViewModel/HelloWidgetViewModel.swift
Outdated
Show resolved
Hide resolved
Student/Student/LearnerDashboard/Widgets/HelloWidget/ViewModel/HelloWidgetViewModel.swift
Show resolved
Hide resolved
Student/Student/LearnerDashboard/Widgets/HelloWidget/ViewModel/HelloWidgetViewModel.swift
Outdated
Show resolved
Hide resolved
Student/Student/LearnerDashboard/Widgets/HelloWidget/View/HelloWidgetView.swift
Outdated
Show resolved
Hide resolved
Student/Student/LearnerDashboard/Widgets/HelloWidget/View/HelloWidgetView.swift
Outdated
Show resolved
Hide resolved
Student/Student/LearnerDashboard/Widgets/HelloWidget/View/HelloWidgetView.swift
Show resolved
Hide resolved
vargaat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA+1, Please fix the retain cycle, otherwise looks good.
Student/Student/LearnerDashboard/Widgets/HelloWidget/ViewModel/HelloWidgetViewModel.swift
Show resolved
Hide resolved
Student/Student/LearnerDashboard/Widgets/HelloWidget/ViewModel/HelloWidgetViewModel.swift
Outdated
Show resolved
Hide resolved
suhaibabsi-inst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code +1
suhaibabsi-inst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA +1
rh12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA + 1
refs: MBL-19531
builds: Student
affects: Student
release note: none
What's new
Created Hello Widget and integrated into Dashboard.
Test plan
Screenshots
Checklist