[MBL-19657][T] SpeedGrader - Fix non-updating late seconds field #3871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-19657 affects: Teacher builds: Teacher release note: Fixed issue where modified late seconds not being saved successfully on SpeedGrader when submitted.
Contributor
Contributor
BuildsCommit: Unit tests (8b5f3e7)
|
…eSeconds-When-Submitted
suhaibabsi-inst
commented
Feb 5, 2026
| self.posted_grade = posted_grade | ||
| self.seconds_late_override = seconds_late_override | ||
|
|
||
| if let seconds = seconds_late_override, seconds >= 0 { |
Contributor
Author
There was a problem hiding this comment.
seconds >= 0 to match the same behavior found on Web (it accepts 0 for late days field without changing the late status).
rh12
deleted the
bugfix/MBL-19657-SpeedGrader-NonSaving-LateSeconds-When-Submitted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: MBL-19657
affects: Teacher
builds: Teacher
release note: Fixed issue where modified late seconds not being saved successfully on SpeedGrader when submitted.
This is to fix non-updating late seconds override for a submission issue. The change was framed in this minimal way after investigating the logic on the code responsible for dealing with this request here:
https://github.com/instructure/canvas-lms/blob/a5efca0d369decb17e8be8f495f4c2cb7425b056/app/controllers/submissions_api_controller.rb#L985
Clearly it requires that we include
late_policy_statusvalue to belatein order to update the value ofseconds_late_overrideon submissions. And this also been expressed in multiple tests like those:https://github.com/instructure/canvas-lms/blob/a5efca0d369decb17e8be8f495f4c2cb7425b056/spec/apis/v1/submissions_api_spec.rb#L4569
https://github.com/instructure/canvas-lms/blob/a5efca0d369decb17e8be8f495f4c2cb7425b056/spec/apis/v1/submissions_api_spec.rb#L4546
Test Plan
1- Open a late submission in SpeedGrader
2- Try editing late days on UI.
3- Upon request is done (load indicator disappearing), the field must show the edited value.
4- Try switching back and forth between statuses
No grade, excused, { .. custom statuses}then set it tolateand try edit late days again.5- All functions should work as expected upon step 4.
Checklist