[MBL-19760][S/T/P] Update Community links #3872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-19760 builds: Student, Teacher, Parent affects: Student, Teacher, Parent release note: none
balintbartok
requested review from
rh12,
suhaibabsi-inst and
vargaat
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR updates Canvas Community help links from the deprecated community.canvaslms.com domain to the new community.instructure.com domain. The changes are straightforward and improve the user experience by directing users to the correct, up-to-date help resources.
Positive Aspects
- Clean, focused changes that update URLs consistently across three key areas (login help, Canvas guides search, and wrong app screen)
- The new URLs are valid and point to appropriate help resources
- Changes follow the existing code patterns and conventions
Issues Found
- Incomplete URL migration: Several files still reference the old
community.canvaslms.comdomain and should be updated for consistency:Core/Core/Features/Courses/SmartSearch/View/CourseSmartSearchHelpView.swift(lines 72, 79, 84)Core/Core/Common/CommonUI/CoreWebView/Model/CoreWebViewJSInjections.swift(line 141 comment)Core/CoreTests/Features/Profile/Help/View/HelpViewTests.swift(line 29)Core/CoreTests/Features/Login/LoginWebViewControllerTests.swift(line 74)
Recommendations
- Consider updating all remaining references to
community.canvaslms.comin the codebase to ensure consistency - Verify that the new URLs are accessible and return the expected content
- Consider adding a test to verify the help URLs are valid and reachable
Security & Performance
No security concerns or performance impacts identified.
Contributor
Contributor
BuildsCommit: Localization files (b7adb5a)
|
rh12
reviewed
Feb 4, 2026
Contributor
rh12
left a comment
rh12
left a comment
There was a problem hiding this comment.
Unless I'm missing something, the updated localization files should be included in the PR as well
Contributor
|
Pushed the loc files |
petkybenedek
approved these changes
Feb 4, 2026
Contributor
Author
thank you, @petkybenedek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: MBL-19760
builds: Student, Teacher, Parent
affects: Student, Teacher, Parent
release note: none
Updated all community links
Test plan