[MBL-19532][S] Learner Dashboard - Course Invitations #3873

vargaat · 2026-02-04T13:57:01Z

What's new?

Added course invitations widget for the Student app's Learner Dashboard.
Added a reusable HorizontalCarouselView component with page indicator support.
Extended Course and Enrollment object save logic to properly link them together. On the old dashboard invitations are fetched directly from API and are not cached in CoreData, now they do. This change affects course and enrollment savings and affects all apps, I poked around and didn't notice any issues but let's keep an eye on this.
Added backgroundReadContext to NSPersistentContainer for thread-safe background CoreData operations.
Removed example FullWidthWidget widget.
Added AcceptCourseInvitation and DeclineCourseInvitation use cases for handling invitation responses and properly updating CoreData cache.
Introduced CoursesInteractor that's purpose is to coordinate all course related data flow via this single interactor. The speciality is, that multiple widgets are able to request courses simultaneously, while only sending out one request towards the API and performing one CoreData write. This is to prevent managed object access races when one widget removes and another one reads the same CoreData entity.
Successful accept/decline actions are confirmed with snack bars, errors are handled with alerts.
Offline mode handled with the usual disabled state and alert.

Known Issues

When resizing the window on iPads the carousel doesn't snap to the nearest page but stays mid way scrolled.
The invitation card is 8 points narrower than the container. This is to achieve paging by adding horizontal paddings to all cards instead of having a spacer on the horizontal stack. If we have separate spacers then after swiping to the second and beyond cards will render cards off-centered.
Full width widgets and grid widgets don't animate as a whole. For example if a course invitation appears, then grid widgets don't nicely animate down but jump to their position. I played around with this a lot but it only made things worse so I settled with this solution.

refs: MBL-19532
builds: Student
affects: Student, Teacher, Parent
release note: none
test plan:

Test the usual features you test on a new UI component.

Screenshots

Checklist

…nsions of stored properties.

…dings.

refs: MBL-19528 builds: Student affects: Student release note: none test plan:

…ions # Conflicts: # Canvas.xcworkspace/xcshareddata/swiftpm/Package.resolved

…ions

Co-authored-by: Attila Varga <[email protected]>

…ions

- Fix carousel layout issues. - Centralize course logic to shared interactor. - Remove no longer needed business logic entities.

…ature/MBL-19532-Course-Invitations # Conflicts: # Student/Student/LearnerDashboard/Widgets/Common/View/DashboardWidgetLayout.swift # Student/Student/LearnerDashboard/Widgets/Common/View/LearnerDashboardWidgetLayoutHelpers.swift # Student/Student/LearnerDashboard/Widgets/DashboardWidgetIdentifier.swift # Student/Student/LearnerDashboard/Widgets/FullWidthWidget/ViewModel/FullWidthWidgetViewModel.swift # Student/Student/LearnerDashboard/Widgets/LearnerDashboardWidgetAssembly.swift

- Fix default widgets not getting ordered properly. - Extracted default widget animation to standalone file. - Removed unnecessary nav title. - Remove unnecessary selfs.

…ature/MBL-19532-Course-Invitations # Conflicts: # Student/Student/LearnerDashboard/Widgets/FullWidthWidget/ViewModel/FullWidthWidgetViewModel.swift

claude

Code Review Summary

This PR implements a comprehensive Course Invitations Widget for the Learner Dashboard. The implementation is well-structured with good separation of concerns, comprehensive test coverage, and follows MVVM architecture. However, there are several critical issues that should be addressed before merging.

🎯 What This PR Does

Adds Core layer APIs for accepting/declining course invitations
Implements a new dashboard widget with horizontal carousel UI
Adds request coalescing for optimized network performance
Includes database schema changes to track enrollment creation dates
Provides comprehensive unit test coverage

✅ Strengths

Clean Architecture: Proper MVVM separation with clear boundaries
Comprehensive Testing: Good test coverage for ViewModels and Interactors
Performance Optimization: Request coalescing prevents duplicate network calls
Reusable Components: HorizontalCarouselView can be reused for other widgets
Error Handling: Most failure scenarios are handled with user feedback

⚠️ Issues Found

I've identified several issues that need attention. Please review the inline comments for specific code locations and recommendations.

Critical Issues (Must Fix)

Memory leak risk in AcceptCourseInvitation.swift - subscriptions never cleared (line 103)
Silent error swallowing in AcceptCourseInvitation.swift - failed fetches are not logged (lines 52-75)
Potential data loss in GetAllUserCourses.swift - deletes courses on partial API failures (lines 88-92)
Race condition in Course.swift - enrollment delete/fetch not synchronized (lines 137-150)
Thread safety concern in CoursesInteractor.swift - subscriptions storage not protected (lines 77-84)

High Priority Issues (Should Fix)

Force unwrapping in Enrollment.swift - could crash if fetch fails (lines 208-209)
Edge case in CourseInvitationCardView.swift - empty section names display as ", " (line 149)
Concurrency edge case in CourseInvitationCardViewModel.swift - rapid accept/decline taps (line 62)

Additional Recommendations

Consider adding UI/integration tests for the complete invitation flow
Add accessibility tests for dynamic content announcements
Add timeout configuration for API requests to prevent indefinite loading states
Consider extracting hardcoded spacing values to design system constants
Add tests for CoreData migration with the new createdAt field

🔍 Testing Notes

The unit tests are comprehensive and cover most success/failure scenarios. Consider adding:

UI tests for the actual widget interaction flow
Performance tests for request coalescing under high load
Edge case tests for horizontal carousel pagination
Accessibility tests for VoiceOver announcements

📝 Architecture Notes

The implementation follows the project's MVVM pattern well. Minor observation: some business logic in CourseInvitationsWidgetViewModel.refresh() could potentially be extracted to the Interactor layer for better separation, but this is not a blocking issue.

Overall, this is a well-crafted feature implementation. Once the critical issues are addressed, particularly around thread safety and error handling, this will be ready to merge.

Core/Core/Features/Enrollments/AcceptCourseInvitation.swift

Student/Student/LearnerDashboard/Container/Model/GetAllUserCourses.swift

Core/Core/Features/Courses/Course.swift

Core/Core/Features/Enrollments/Enrollment.swift

...Student/LearnerDashboard/Widgets/CourseInvitationsWidget/View/CourseInvitationCardView.swift

...arnerDashboard/Widgets/CourseInvitationsWidget/ViewModel/CourseInvitationCardViewModel.swift

Student/Student/LearnerDashboard/Container/Model/CoursesInteractor.swift

inst-danger · 2026-02-04T14:09:29Z

	Warnings
⚠️	This pull request will not generate a release note.

Affected Apps: Student, Teacher, Parent

Builds: Student

MBL-19532

Coverage	New %	Master %	Delta
Canvas iOS	91.49%	81.06%	10.42%

Generated by 🚫 dangerJS against 09bb788

inst-danger · 2026-02-04T14:12:03Z

Builds

Commit: Remove extra new line. (09bb788)
Build Number: 1267
Built At: Feb 06 17:11 CET (02/06 09:11 AM MST)

Student

# Conflicts: # Student/Student/LearnerDashboard/Widgets/Common/View/DashboardWidgetLayout.swift

petkybenedek · 2026-02-05T15:18:55Z

Code +1

suhaibabsi-inst

QA +1

Tested on iPhone 16, iOS 26.2.

suhaibabsi-inst · 2026-02-05T14:49:14Z

Core/Core/Features/Enrollments/DeclineCourseInvitation.swift

+import CoreData
+import Foundation
+
+public class DeclineCourseInvitation: UseCase {


Interesting way of using UseCase!

Just realized I could have used DeleteUseCase to make this simpler. Next time.

# Conflicts: # Student/Student/LearnerDashboard/Widgets/LearnerDashboardWidgetAssembly.swift # Student/Student/Localizable.xcstrings # Student/StudentUnitTests/LearnerDashboard/Container/Model/LearnerDashboardInteractorTests.swift

petkybenedek

It's hard to see the individual cards in dark mode. Not connected to this pr.

Approved otherwise

Student/Student/LearnerDashboard/Container/Model/CoursesInteractor.swift

...erDashboard/Widgets/CourseInvitationsWidget/ViewModel/CourseInvitationsWidgetViewModel.swift

Core/Core/Features/Courses/Course.swift

Student/StudentUnitTests/LearnerDashboard/Container/Model/CoursesLiveInteractorTests.swift

...nt/StudentUnitTests/LearnerDashboard/Container/Model/CoursesInteractorInvitationsTests.swift

...erDashboard/Widgets/CourseInvitationsWidget/ViewModel/CourseInvitationsWidgetViewModel.swift

rh12 · 2026-02-06T12:07:30Z

...dent/LearnerDashboard/Widgets/CourseInvitationsWidget/View/CourseInvitationsWidgetView.swift

+    @State private var totalPages: Int = 1
+
+    var body: some View {
+        ZStack {


Do we need the ZStack?

Without this, the preview doesn't appear. I tried moving the ZStack to the preview but didn't fix it. If you feel you can play with it, I'm also curious what happens there.

...arnerDashboard/Widgets/CourseInvitationsWidget/ViewModel/CourseInvitationCardViewModel.swift

...Student/LearnerDashboard/Widgets/CourseInvitationsWidget/View/CourseInvitationCardView.swift

Student/Student/LearnerDashboard/Widgets/Common/View/HorizontalCarouselView.swift

rh12

QA + 1 (tested on iPhone @ 26, iPad @ 18)

Thanks for all the changes!

vargaat and others added 30 commits January 7, 2026 14:51

Make some properties public on SessionDefaults to allow external exte…

70bd109

…nsions of stored properties.

Add skeleton architecture.

37a43e7

Style updates.

bce4cae

Add state to widgets. Add example transitions. Fix animations and pad…

901b44e

…dings.

Animation fixes. Renaming.

281a8b7

Layout updates

22442de

refs: MBL-19528 builds: Student affects: Student release note: none test plan:

Add tests.

8e0097e

Merge branch 'master' into feature/MBL-19528-dashboard-widget-foundat…

325c7f2

…ions # Conflicts: # Canvas.xcworkspace/xcshareddata/swiftpm/Package.resolved

Add empty protocol file to code coverage exclusion list.

f7da8c0

Merge branch 'master' into feature/MBL-19528-dashboard-widget-foundat…

fb666ce

…ions

Add carousel widget and course invitations skeleton.

e9ce333

Merge branch 'master' into feature/MBL-19532-Course-Invitations

563a72a

Add thread safe course fetch interactor.

0031e87

Update profile button color to use textDarkest

e82ebe2

Co-authored-by: Attila Varga <[email protected]>

Merge branch 'master' into feature/MBL-19528-dashboard-widget-foundat…

1f9ebd2

…ions

Rename files.

f2941ce

Implement code review suggestions.

1737e5c

- Remove example horizontal widget.

34dbb60

- Fix carousel layout issues. - Centralize course logic to shared interactor. - Remove no longer needed business logic entities.

Add previews and animations.

cebd361

Improve error and success feedback on ui.

703d4ec

- Fix menu button color on iOS 26.

cf63c3c

- Fix default widgets not getting ordered properly. - Extracted default widget animation to standalone file. - Removed unnecessary nav title. - Remove unnecessary selfs.

Fix widget title not getting resized on font size change.

89630b7

Fix swiftlint.

c15fc51

Merge branch 'feature/MBL-19528-dashboard-widget-foundations' into fe…

ffcc50a

…ature/MBL-19532-Course-Invitations # Conflicts: # Student/Student/LearnerDashboard/Widgets/FullWidthWidget/ViewModel/FullWidthWidgetViewModel.swift

Use shared animation.

bf318cb

Merge branch 'master' into feature/MBL-19532-Course-Invitations

d3651da

Use pill buttons.

9910d83

Remove offline warnings from view model.

f7ec2e7

Improve accessibility.

b32afc9

vargaat added 5 commits February 3, 2026 17:56

Move helper to a better place.

04e5519

Improve preview.

fa3dd52

Work around animation glitches.

d4e5800

Properly update database after invitation status changes.

25f566b

Fix retain cycle.

32c0aa3

vargaat self-assigned this Feb 4, 2026

claude bot reviewed Feb 4, 2026

View reviewed changes

vargaat added 3 commits February 4, 2026 16:46

Update unit test.

ebea358

Merge branch 'master' into feature/MBL-19532-Course-Invitations

0aa5a52

# Conflicts: # Student/Student/LearnerDashboard/Widgets/Common/View/DashboardWidgetLayout.swift

Improve empty section name handling.

727064b

vargaat marked this pull request as ready for review February 4, 2026 16:34

vargaat requested review from rh12 and suhaibabsi-inst as code owners February 4, 2026 16:34

Remove auto widget refresh.

38d01a0

suhaibabsi-inst previously approved these changes Feb 5, 2026

View reviewed changes

vargaat dismissed suhaibabsi-inst’s stale review via 7c43add February 5, 2026 16:15

petkybenedek previously approved these changes Feb 5, 2026

View reviewed changes

rh12 reviewed Feb 6, 2026

View reviewed changes

Implement review findings. Revert accept and decline button order.

6332477

vargaat dismissed petkybenedek’s stale review via 6332477 February 6, 2026 15:42

Remove extra new line.

09bb788

vargaat requested review from rh12 and suhaibabsi-inst February 6, 2026 16:19

rh12 approved these changes Feb 6, 2026

View reviewed changes

rh12 merged commit 21720c8 into master Feb 6, 2026
5 checks passed

rh12 deleted the feature/MBL-19532-Course-Invitations branch February 6, 2026 17:48

[MBL-19532][S] Learner Dashboard - Course Invitations #3873

[MBL-19532][S] Learner Dashboard - Course Invitations #3873

Uh oh!

Conversation

vargaat commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's new?

Known Issues

Screenshots

Checklist

Uh oh!

claude bot left a comment • edited by vargaat Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Code Review Summary

🎯 What This PR Does

✅ Strengths

⚠️ Issues Found

Critical Issues (Must Fix)

High Priority Issues (Should Fix)

Additional Recommendations

🔍 Testing Notes

📝 Architecture Notes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inst-danger commented Feb 4, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Affected Apps: Student, Teacher, Parent

Builds: Student

Uh oh!

inst-danger commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Builds

Uh oh!

petkybenedek commented Feb 5, 2026

Uh oh!

suhaibabsi-inst left a comment

Choose a reason for hiding this comment

Uh oh!

suhaibabsi-inst Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

vargaat Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

petkybenedek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rh12 Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

vargaat Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rh12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

vargaat commented Feb 4, 2026 •

edited

Loading

claude bot left a comment •

edited by vargaat

Loading

inst-danger commented Feb 4, 2026 •

edited by atlassian bot

Loading

inst-danger commented Feb 4, 2026 •

edited

Loading