[CLXR-294][S] Fix learning Library bug bash bugs #3929
Open
Ahmed-Naguib93 wants to merge 25 commits intofeature/career-Learning-Library-CLX-3773from
Open
[CLXR-294][S] Fix learning Library bug bash bugs #3929Ahmed-Naguib93 wants to merge 25 commits intofeature/career-Learning-Library-CLX-3773from
Ahmed-Naguib93 wants to merge 25 commits intofeature/career-Learning-Library-CLX-3773from
Conversation
refs: CLXR-293 builds: student affects: student release note: none test plan: none
refs: CLXR-279 builds: Student affects: Student release note: none test plan: none
refs: CLXR-292 builds: Student affects: Student release note: none test plan: none
refs: CLXR-287, CLXR-288, CLXR-294 builds: Student affects: Student release note: none test plan: none
refs: CLXR-280 builds: Student affects: Student release note: none test plan: none
refs: CLXR-290 builds: Student affects: Student release note: none test plan: none
refs: CLXR-289 builds: Student affects: Student release note: none test plan: none
refs: CLXR-286 builds: Student affects: Student release note: none test plan: none
Ahmed-Naguib93
requested review from
JacksonHowe,
ktheory and
szabinst
as code owners
Contributor
…career-fix-bug-bash-LL
Contributor
Affected Apps: StudentBuilds: Student❌ Swift lint |
Contributor
BuildsCommit: chore: remove unneeded code (d8504f6)
|
Contributor
Contributor
Contributor
szabinst
reviewed
Mar 12, 2026
Collaborator
szabinst
left a comment
szabinst
left a comment
There was a problem hiding this comment.
There are a number of commented out program related lines. If those won't be used anymore, please remove them completely.
Horizon/Horizon/Sources/Features/Learn/LearningLibrary/Data/LearningLibraryObjectType.swift
Outdated
Show resolved
Hide resolved
...n/Sources/Features/Learn/LearningLibrary/ListLearningLibrary/Views/LearningLibraryView.swift
Outdated
Show resolved
Hide resolved
Horizon/Horizon/Sources/Features/Learn/LearningLibrary/LearningLibraryItemNavigating.swift
Outdated
Show resolved
Hide resolved
Contributor
Contributor
Contributor
Ahmed-Naguib93
requested review from
petkybenedek,
rh12,
suhaibabsi-inst and
vargaat
as code owners
Contributor
…career-fix-bug-bash-LL
Contributor
Contributor
Affected Apps: StudentBuilds: Student
|
szabinst
reviewed
Mar 16, 2026
...UnitTests/Features/Learn/LearningLibrary/Navigation/LearningLibraryItemNavigatingTests.swift
Outdated
Show resolved
Hide resolved
Contributor
Affected Apps: StudentBuilds: Student
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: CLXR-279, CLXR-280, CLXR-287, CLXR-288, CLXR-289, CLXR-290,CLXR-292, CLXR-293, CLXR-294
builds: Student
affects: Student
release note: none
test plan: none