[MBL-19538][S] Learner Dashboard - To-do Widget#3934
Draft
domonkosadam wants to merge 29 commits intomasterfrom
Draft
[MBL-19538][S] Learner Dashboard - To-do Widget#3934domonkosadam wants to merge 29 commits intomasterfrom
domonkosadam wants to merge 29 commits intomasterfrom
Conversation
refs: MBL-19538 builds: Student affects: Student release note: none
domonkosadam
requested review from
petkybenedek,
rh12,
suhaibabsi-inst and
vargaat
as code owners
Contributor
BuildsNo apps were built for this pull request. To trigger app builds, include a line starting with Commit: Resolve conflict (ee8c8d5) |
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Affected Apps: StudentBuilds: Student
|
petkybenedek
changed the title
petkybenedek
requested changes
Mar 12, 2026
Student/Student/LearnerDashboard/Widgets/ToDoWidget/View/ToDoWidgetView.swift
Outdated
Show resolved
Hide resolved
Student/Student/LearnerDashboard/Widgets/ToDoWidget/View/ToDoWidgetView.swift
Outdated
Show resolved
Hide resolved
Student/Student/LearnerDashboard/Widgets/LearnerDashboardWidgetAssembly.swift
Show resolved
Hide resolved
# Conflicts: # Student/Student/LearnerDashboard/Widgets/DashboardWidgetIdentifier.swift
Contributor
rh12
reviewed
Mar 13, 2026
| import Core | ||
| import SwiftUI | ||
|
|
||
| struct ToDoWidgetView: View { |
Contributor
There was a problem hiding this comment.
Week overlay buttons
-
Replace ZStack with overlay,eliminate geometry observations - Use icons
- Remove/rework accessibilityRepresentation
- Support scaling
Card header
- Move all formatting to stored viewModel properties
Week pager
- Fix dynamic font size issues
- On paging: Keep selected day instead of todays's day
ToDo list
- Consolidate empty/error panda
- Revisit skeleton cell count (ideas: last count, always 1)
Misc
- Fix card moving up/down on Today button show/hide
- Extract subviews
- Update color usage (after Settings PR is merged)
- Remove Add ToDo screen Done button
| import SwiftUI | ||
|
|
||
| @Observable | ||
| final class ToDoWidgetViewModel: DashboardWidgetViewModel { |
Contributor
There was a problem hiding this comment.
- Fix snackbar not always displaying
- Fix todos not always loading
- Fix sync issues between widget and tab (items reordered after PTR on tab, etc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: MBL-19538
builds: Student
affects: Student
release note: none
Screenshots
Checklist